Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] Update app test fixture #8584

Merged
merged 1 commit into from Sep 19, 2022
Merged

[next] Update app test fixture #8584

merged 1 commit into from Sep 19, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 19, 2022

Related Issues

Updates our test fixture for related changes in latest canary of Next.js.

Fixes: https://vercel.slack.com/archives/CGU8HUTUH/p1663607276817069

馃搵 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@ijjk ijjk added semver: patch PR contains bug fixes area: next labels Sep 19, 2022
@ijjk ijjk marked this pull request as ready for review September 19, 2022 19:48
@ijjk ijjk requested a review from huozhi September 19, 2022 19:48
@huozhi huozhi mentioned this pull request Sep 19, 2022
Closed
4 tasks
@ijjk ijjk merged commit 1f30e3a into main Sep 19, 2022
@ijjk ijjk deleted the ijjk/update-app-fixture branch September 19, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

@huozhi huozhi huozhi approved these changes

@EndangeredMassa EndangeredMassa Awaiting requested review from EndangeredMassa EndangeredMassa is a code owner

@styfle styfle Awaiting requested review from styfle

@cb1kenobi cb1kenobi Awaiting requested review from cb1kenobi

@Ethan-Arrowood Ethan-Arrowood Awaiting requested review from Ethan-Arrowood Ethan-Arrowood is a code owner

Assignees
No one assigned
Labels
area: next semver: patch PR contains bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijjk @TooTallNate @huozhi