[cli] Use project settings and env vars from "vc pull" during "vc dev" #8666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooTallNate
changed the title
.vercel/.env.development.local in "vc build"
4 tasks
|
Since this is marked as semver-major, lets remove the reading of That will fix this related issue: |
TooTallNate
changed the title
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 18, 2022
The `link` and `pull` commands have essentially duplicate code from `ensureLink()`. This Card: https://linear.app/vercel/issue/VCCLI-224/adopt-ensurelink-across-commands The `dev` command should also be updated to use `ensureLink()`, however that may interfere with this in progress PR: #8666. ### 📋 Checklist #### Tests - [x] The code changed/added as part of this PR has been covered with tests - [x] All tests pass locally with `yarn test-unit` #### Code Review - [x] This PR has a concise title and thorough description useful to a reviewer - [x] Issue from task tracker has a link to this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
vc devto utilize the project settings and environment variables that were pulled fromvc pull. This allows forvc devto be run offline, since no API requests will be make at boot-up time any more.