Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli][fs-detectors] Improve vc build monorepo support #8742

Merged
merged 35 commits into from
Nov 14, 2022
Merged

[cli][fs-detectors] Improve vc build monorepo support #8742

merged 35 commits into from
Nov 14, 2022

Conversation

Ethan-Arrowood
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood commented Oct 18, 2022 •
edited
Loading

Related Issues

Improves how vc build handles monorepos. In short, this introduces monorepo manager detection logic and then some helpful defaults so users don't have to manually specify a buildCommand or installCommand when linking a project within a monorepo.

📋 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

agadzik
agadzik reviewed Oct 18, 2022
View reviewed changes
packages/cli/src/commands/build.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/build.ts Outdated Show resolved Hide resolved
@Ethan-Arrowood Ethan-Arrowood marked this pull request as ready for review October 25, 2022 23:39
@Ethan-Arrowood Ethan-Arrowood changed the title [WIP] [cli][@vercel/fs-detectors] Improve vc build monorepo support [cli][@vercel/fs-detectors] Improve vc build monorepo support Oct 25, 2022
@styfle styfle changed the title [cli][@vercel/fs-detectors] Improve vc build monorepo support [cli][fs-detectors] Improve vc build monorepo support Oct 26, 2022
Ethan-Arrowood
Ethan-Arrowood commented Oct 27, 2022
View reviewed changes
Copy link
Contributor Author

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-reviewed to get discussions going. This PR has become very large, I think I can pull out the @types/node update if folks care about scope-creep.

I'm going to say that the integration test changes are necessary. The existing integration test file was simply not extensible enough to support the multitude of scenarios we need to be testing for this feature.

packages/cli/package.json Outdated Show resolved Hide resolved
packages/cli/package.json Outdated Show resolved Hide resolved
packages/cli/src/commands/build.ts Outdated Show resolved Hide resolved
packages/cli/src/util/client.ts Outdated Show resolved Hide resolved
packages/cli/src/util/dev/builder.ts Outdated Show resolved Hide resolved
packages/cli/test/helpers/prepare.js Outdated Show resolved Hide resolved
packages/cli/test/helpers/prepare.js Outdated Show resolved Hide resolved
packages/fs-detectors/src/isError.ts Outdated Show resolved Hide resolved
packages/fs-detectors/src/packageManagers/package-managers.ts Outdated Show resolved Hide resolved
packages/fs-detectors/test/unit.local-file-system-detector.test.ts Show resolved Hide resolved
This was referenced Oct 31, 2022
Closed
Merged
styfle pushed a commit that referenced this pull request Nov 2, 2022
[error-utils] Create @vercel/error-utils package (#8828)
49f4537 
While working on #8742 i found some useful error checking code buried in
the CLI. This PR adds a new private package `@vercel/errors` that moves
those helpful utilities into its own package so it can be used
throughout the monorepo.
@r0hack r0hack mentioned this pull request Nov 14, 2023
Open
This was referenced Nov 14, 2023
Open
Open
@r0hack r0hack mentioned this pull request Nov 14, 2023
Open
@zachlewis2020 zachlewis2020 mentioned this pull request Nov 14, 2023
Open
This was referenced Nov 14, 2023
Open
Open
Open
@r0hack r0hack mentioned this pull request Nov 14, 2023
Open
This was referenced Nov 14, 2023
Open
Open
@kwnstantina kwnstantina mentioned this pull request Nov 15, 2023
Open
This was referenced Nov 15, 2023
Open
Open
This was referenced Nov 15, 2023
Open
Open
This was referenced Nov 15, 2023
Open
Open
Open
Open
@zachlewis2020 zachlewis2020 mentioned this pull request Nov 15, 2023
Open
This was referenced Nov 15, 2023
Open
Open
Open
Open
Open
Open
@zachlewis2020 zachlewis2020 mentioned this pull request Jan 9, 2024
Open
@r0hack r0hack mentioned this pull request Jan 9, 2024
Open
@kwnstantina kwnstantina mentioned this pull request Jan 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agadzik agadzik agadzik left review comments

@TooTallNate TooTallNate TooTallNate approved these changes

@EndangeredMassa EndangeredMassa Awaiting requested review from EndangeredMassa EndangeredMassa is a code owner

@styfle styfle Awaiting requested review from styfle

@cb1kenobi cb1kenobi Awaiting requested review from cb1kenobi

@chloetedder chloetedder Awaiting requested review from chloetedder chloetedder is a code owner

Assignees
No one assigned
Labels
area: cli area: fs-detectors pr: automerge Automatically merge the PR when checks pass semver: minor PR contains new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ethan-Arrowood @TooTallNate @agadzik