Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] add eslintcache #8993

Merged
merged 2 commits into from
Dec 19, 2022
Merged

[tests] add eslintcache #8993

merged 2 commits into from
Dec 19, 2022

Conversation

Simon-He95
Copy link
Contributor

@Simon-He95 Simon-He95 commented Dec 1, 2022 •
edited by styfle

No description provided.

@styfle styfle changed the title chore: add eslintcache [tests] add eslintcache Dec 19, 2022
@styfle styfle added area: tests semver: patch PR contains bug fixes pr: automerge Automatically merge the PR when checks pass labels Dec 19, 2022
@vercel
Copy link

vercel bot commented Dec 19, 2022

@styfle is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

styfle
styfle approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We might need to cache the results in GH Actions too but that can be a separate PR

cb1kenobi
cb1kenobi approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good idea. I did some testing and it appears to be relatively safe, so let's give it a go.

@styfle styfle merged commit 6180701 into vercel:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

@styfle styfle styfle approved these changes

@TooTallNate TooTallNate Awaiting requested review from TooTallNate TooTallNate is a code owner

@EndangeredMassa EndangeredMassa Awaiting requested review from EndangeredMassa EndangeredMassa is a code owner

@Ethan-Arrowood Ethan-Arrowood Awaiting requested review from Ethan-Arrowood

Assignees
No one assigned
Labels
area: tests pr: automerge Automatically merge the PR when checks pass semver: patch PR contains bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Simon-He95 @cb1kenobi @styfle