[frameworks] add envPrefix to hydrogen framework
#9326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stipsan
requested review from
TooTallNate,
EndangeredMassa,
styfle,
cb1kenobi and
Ethan-Arrowood
as code owners
styfle
changed the title
envPrefix to hydrogen frameworkenvPrefix to hydrogen framework
styfle
added
area: frameworks
semver: patch
Ethan-Arrowood
removed
the
pr: automerge
|
We're doing some testing to make sure this works in production. We may also need a change in packages/hydrogen to support this properly. We'll report back. |
stipsan
force-pushed
the
patch-1
branch
3 times, most recently
from
9cd9d2b
to
497b885
Compare
|
I'm going to merge this one and create a new PR to make sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hydrogen uses the
PUBLIC_env prefix, it also supportsVITE_but the docs only talk aboutPUBLIC_.