Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli][dev] remove link to 404 FAQ #9508

Merged
merged 4 commits into from
Feb 27, 2023

Conversation

EndangeredMassa
Copy link
Contributor

@EndangeredMassa EndangeredMassa commented Feb 22, 2023

In a previous PR (https://github.com/vercel/vercel/pull/8976/files#diff-bd86ad03c67b58fd8df71509a96d1e303343068bbe3addc19cd3cb7247db98b4R10), a link was added to the 404 template that directed the user to https://vercel.link/404. The information at that link talks about deployments, which is confusing working from vc dev locally.

This appears to be the only reference to https://vercel.link/404. Can anyone find others?

Should we make a new FAQ entry we can link to or just remove this link? If we want specific documentation about this, should it live under https://vercel.com/docs/cli ?


@@ -6,6 +6,4 @@
{{?}}
<span class="devinfo-line">ID: <code>{{! it.request_id }}</code>
</p>

<a href="https://vercel.link/404"><div class="note">Click here to learn more about this error.</div></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this code is generated so it would probably end up here again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believed these were manually updated by us from time to time

@EndangeredMassa EndangeredMassa added the pr: automerge Automatically merge the PR when checks pass label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli area: dev pr: automerge Automatically merge the PR when checks pass semver: patch PR contains bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants