-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli][dev] remove link to 404 FAQ #9508
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndangeredMassa
requested review from
TooTallNate,
styfle,
cb1kenobi and
Ethan-Arrowood
as code owners
February 22, 2023 17:06
styfle
reviewed
Feb 22, 2023
@@ -6,6 +6,4 @@ | |||
{{?}} | |||
<span class="devinfo-line">ID: <code>{{! it.request_id }}</code> | |||
</p> | |||
|
|||
<a href="https://vercel.link/404"><div class="note">Click here to learn more about this error.</div></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this code is generated so it would probably end up here again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believed these were manually updated by us from time to time
styfle
approved these changes
Feb 22, 2023
cb1kenobi
approved these changes
Feb 22, 2023
EndangeredMassa
added
the
pr: automerge
Automatically merge the PR when checks pass
label
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: cli
area: dev
pr: automerge
Automatically merge the PR when checks pass
semver: patch
PR contains bug fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR (https://github.com/vercel/vercel/pull/8976/files#diff-bd86ad03c67b58fd8df71509a96d1e303343068bbe3addc19cd3cb7247db98b4R10), a link was added to the 404 template that directed the user to https://vercel.link/404. The information at that link talks about deployments, which is confusing working from
vc dev
locally.This appears to be the only reference to https://vercel.link/404. Can anyone find others?
Should we make a new FAQ entry we can link to or just remove this link? If we want specific documentation about this, should it live under https://vercel.com/docs/cli ?