[tests] Properly test for multiple headers with same name in probes #9538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the `responseHeaders` probe checks to properly test for multiple headers with the same name. Previously the probes were using `headers.get()` which concats multiple headers into a single string, which results in the check not really checking if there are in fact multiple headers with the same name. Using `headers.raw()` allows us to properly test for that. A couple of Python tests that were already checking for multiple `set-cookie` headers needed to be updated to match the full value, since the check now properly validates the full string match of each header (before it was basically just doing a `string.includes()` check). This is a precursor for #9533.
TooTallNate
requested review from
EndangeredMassa,
styfle,
cb1kenobi and
Ethan-Arrowood
as code owners
TooTallNate
added
area: tests
pr: automerge
Ethan-Arrowood
approved these changes
Feb 24, 2023
cb1kenobi
approved these changes
Feb 24, 2023
styfle
reviewed
Feb 24, 2023
| const headers = Array.from(resp.headers.entries()) | ||
| .map(([k, v]) => ` ${k}=${v}`) | ||
| .join('\n'); | ||
| const actualArr = rawHeaders[header.toLowerCase()]; |
There was a problem hiding this comment.
Are raw headers always lowercase keys?
There was a problem hiding this comment.
So why is the header.toLowerCase() there? Are we assuming the server will always lowercase the key before sending the response?
There was a problem hiding this comment.
I guess so. Some existing tests were using lowercase.
styfle
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
responseHeadersprobe checks to properly test for multiple headers with the same name.Previously the probes were using
headers.get()which concats multiple headers into a single string, which results in the test not really checking if there are in fact multiple headers with the same name. Usingheaders.raw()allows us to properly test for that.A couple of Python tests that were already checking for multiple
set-cookieheaders needed to be updated to match the full value, since the check now properly validates the full string match of each header (before it was basically just doing astring.includes()check).This is a precursor for #9533.