[cli] Added fetch dist-tags http status validation #9549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
added
area: cli
semver: patch
cb1kenobi
requested review from
TooTallNate,
EndangeredMassa,
styfle and
Ethan-Arrowood
as code owners
Ethan-Arrowood
approved these changes
Feb 24, 2023
styfle
reviewed
Feb 24, 2023
styfle
approved these changes
Feb 24, 2023
kodiakhq
bot
deleted the
chrisbarber/get-latest-better-error-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for some reason the
get-latest-worker.jsfails to get the dist-tags, it doesn't check the status code and proceeds toJSON.parse()the response. If for example npm returns 401 Unauthorized, you get a cryptic JSON parse error message.