[remix] Inject Edge entrypoint into @remix-run/vercel during Edge Function creation
#9553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction creation There's a PR opened on Remix to add an Edge compatible entrypoint to @remix-run/vercel. This is only really needed specifically for projects that have a custom server.js entrypoint file, which is not strictly necessary anymore, but there are some edge cases where a project might still want to have one. So this PR is necessary for those kinds of projects to be able to use Edge runtime. Even when they merge the PR, it would be good to leave this injection code around for some time to continue support for older @remix-run/vercel versions in existing projects.
TooTallNate
requested review from
EndangeredMassa,
styfle,
cb1kenobi and
Ethan-Arrowood
as code owners
Ethan-Arrowood
previously approved these changes
Feb 24, 2023
…' of github.com:vercel/vercel into tootallnate/vccli-549-inject-edge-entrypoint-into-remix
TooTallNate
deleted the
tootallnate/vccli-549-inject-edge-entrypoint-into-remix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a PR opened on Remix to add an Edge compatible entrypoint to
@remix-run/vercel. This is only really needed specifically for projects that have a custom server.js entrypoint file, which is not strictly necessary anymore, but there are some edge cases where a project might still want to have one. So this PR is necessary for those kinds of projects to be able to use Edge runtime.Even when they merge the PR, it would be good to leave this injection code around for some time to continue support for older
@remix-run/vercelversions in existing projects.