[frameworks] Check for remix.config.mjs for "remix" auto-detection
#9558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooTallNate
requested review from
EndangeredMassa,
styfle,
cb1kenobi and
Ethan-Arrowood
as code owners
TooTallNate
added
area: frameworks
semver: patch
styfle
approved these changes
Feb 27, 2023
| @@ -202,12 +202,13 @@ export const frameworks = [ | |||
| useRuntime: { src: 'package.json', use: '@vercel/remix' }, | |||
| ignoreRuntimes: ['@vercel/node'], | |||
| detectors: { | |||
| every: [ | |||
| // Intentionally does not detect a package name | |||
| // https://github.com/vercel/vercel/pull/7761 | |||
There was a problem hiding this comment.
Why was this comment removed? It's a note that makes sure we don't think we can replace this with something like matchPackage: 'remix' later.
I don't think it's necessarily required, but if we're removing these comments, let's remove the other comments about this from this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving this to a separate PR based on this comment: #9556 (comment)
This will need to be merged and released before the relevant E2E test in #9556 will pass.