Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Next.js 8 to Next.js 12 #50

Merged
merged 37 commits into from
Mar 7, 2022
Merged

Upgrade from Next.js 8 to Next.js 12 #50

merged 37 commits into from
Mar 7, 2022

Conversation

lydiahallie
Copy link
Contributor

@lydiahallie lydiahallie commented Mar 1, 2022 •
edited
Loading

This PR updates the next version from 8 to 12, and adds the changes necessary for this upgrade.

  • Upgrade from Next.js 8 to Next.js 12
  • Replace "Zeit" references with "Vercel"
  • Use getStaticProps and getStaticPaths in favor of getInitialProps to enable SSG
  • Add dynamic routing to the /model/[id] page
  • Add Typescript support
  • Update 3rd party dependencies
  • Use Airtable instead of MongoDB to fetch model data

@vercel
Copy link

vercel bot commented Mar 1, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/vrs/FydqHqFan7Qk8Bk3DSPxNS3rDo1t
✅ Preview: https://vrs-git-lydiahallie-update-next-version.vercel.sh

leerob
leerob reviewed Mar 1, 2022
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing!

frontend/components/Comment.js Show resolved Hide resolved
frontend/components/Slider.js Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Mar 1, 2022

Deployment failed with the following error:

`builds[1]` missing required property `use`

@leerob
Copy link
Member

leerob commented Mar 3, 2022

CleanShot 2022-03-02 at 21 02 45@2x

Small issue, but code is looking good!

@leerob leerob marked this pull request as ready for review March 3, 2022 22:17
@leerob
Copy link
Member

leerob commented Mar 3, 2022

The shape of the 3D grid appears to have shifted from circles to squares. Any ideas?

@lydiahallie lydiahallie changed the title Update next version Upgrade from Next.js 8 to Next.js 12 Mar 7, 2022
@lydiahallie lydiahallie merged commit 74d33b0 into master Mar 7, 2022
@lydiahallie lydiahallie deleted the lydiahallie/update-next-version branch March 7, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leerob leerob leerob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lydiahallie @vercel-team @leerob