fix: handle Windows style path in generateWildcardRequire

[yichi-yang]

Fixes #154

[styfle]

Thanks! It would be great to add a test for this so we can ensure we don't regress (I'll have to enable windows CI in the future)

[yichi-yang]

Thanks! It would be great to add a test for this so we can ensure we don't regress (I'll have to enable windows CI in the future)

I added a unit test for #154. I tried on my Windows machine and it passes after the fix 48d3692 (but fails before the fix, reproducing the bug).

---

Actually running the tests on my machine caught another bug related to path separators. But I think that might be a separate issue and is better fixed in another PR?

Edit: I've figured this one out. JSON.stringify(curPattern) escapes the \ and .replace turns it into two /s.

webpack-asset-relocator-loader/src/asset-relocator.js

Line 516 in 302654e

assetExpressions += " + \'" + JSON.stringify(curPattern).replace(/\\/g, '/').slice(1, -1) + "'";

Let me know if you want the fix in this PR or a separate one.

  ● should generate correct output for wildcard2

    expect(received).toBe(expected) // Object.is equality

    - Expected  - 1
    + Received  + 1

    @@ -42,11 +42,11 @@
      var __webpack_exports__ = {};
      // This entry need to be wrapped in an IIFE because it need to be isolated against other modules in the chunk.
      (() => {
      const path = __webpack_require__(622);

    - fs.readFileSync(__webpack_require__.ab + "wildcard2/" + unknown + '/asset1.txt');
    + fs.readFileSync(__webpack_require__.ab + "wildcard2/" + unknown + '//asset1.txt');


      })();

      module.exports = __webpack_exports__;

      112 |       .replace(/\r/g, "");
      113 |     try {
    > 114 |       expect(actual).toBe(expected);
          |                      ^
      115 |     } catch (e) {
      116 |       // useful for updating fixtures
      117 |       fs.writeFileSync(`${testDir}/actual.js`, actual);

      at Object.toBe (test/index.test.js:114:22)

[styfle]

Thanks! Lets do a separate PR for the other fix since this one looks good 👍

[github-actions]

🎉 This PR is included in version 1.7.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[styfle]

I added windows to CI in #155 but looks like there is more work to make it compatible