This repository has been archived by the owner on Jan 16, 2022. It is now read-only.
Refactor: migrating Flow to Typescript #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpicado
reviewed
May 4, 2019
juanpicado
reviewed
May 4, 2019
juanpicado
reviewed
May 4, 2019
juanpicado
reviewed
May 4, 2019
juanpicado
reviewed
May 4, 2019
juanpicado
reviewed
May 4, 2019
juanpicado
reviewed
May 4, 2019
juanpicado
suggested changes
May 4, 2019
There was a problem hiding this comment.
Remember, to make this works, we cannot change any library yet and no refactorings. We must coordinate since we have other PR in progress and any new bug might be reported anytime while this is PR is open. I'll go with 100% merges from 4.x-master, but it is gonna be challenging since the files are basically new.
I will help on this after May 15th launch. 👍
Good job 👏
…github.com/verdaccio/ui into refactor/7_convert_flow_type_to_typescript
|
@juanpicado Thank you! About the Search test it was my fault...I forgot to remove the "test.only" from one test...Now it should be fine :-) |
eslint needs expecitely to know which file has to lint, by default is JS, in this case we need also ts,tsx files eslint . --ext .js,.ts
chore: clean warnings chore: remove github actions test phases chore: remove dupe rule
- loading images with css is more performant than using img html tags, switching this might be a breaking change - restore no-empty-source seems the linting do not accept false - update snapshots - remove @material-ui/styles
juanpicado
force-pushed
the
refactor/7_convert_flow_type_to_typescript
branch
from
a95a2b6
to
f205bb3
Compare
juanpicado
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
It has been a long way, but we get there. I updated the PR content @priscilawebdev according to the changes of this PR. Thanks, good job 👏
juanpicado
added
4.x-master
enhancement
delete-merged-branch
bot
deleted the
refactor/7_convert_flow_type_to_typescript
branch
sergiohgz
added a commit
that referenced
this pull request
Jul 9, 2019
- Remove unnecessary quotes in Emotion css templated string - Revert md prop removed in #47 (with the size set before that)
juanpicado
added a commit
to verdaccio/verdaccio
that referenced
this pull request
Jul 29, 2019
- fix: https://github.com/verdaccio/ui/issues/76 - fix: https://github.com/verdaccio/ui/issues/75 - fix: verdaccio/ui#106 - feat: verdaccio/ui#47 Co-Authored-By: Priscila Oliveira <priscilawebdev@gmail.com> Co-Authored-By: Sergio Hg <sergiohgz@users.noreply.github.com> Co-Authored-By: Griffith <griffithtp@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR convert the code base to Typescript, the changes are the following:
eslintand@typescript-eslint/eslint-plugin(warnings still need to be addressed in future pull requestbundlezise(it was disabled for some reason)