Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to TypeScript #1166

Closed
stackdumper opened this issue Dec 22, 2018 · 6 comments · Fixed by #1374
Closed

Switch to TypeScript #1166

stackdumper opened this issue Dec 22, 2018 · 6 comments · Fixed by #1374

Comments

@stackdumper
Copy link
Member

As for me, TypeScript is much more convenient and has better integrations for code editors. I believe switching to TS would allow Verdaccio to evolve faster and would encourage contributors and, especially, plugin developers.

@juanpicado
Copy link
Member

We are working on it, first step #1164
It won't happen soon. After release v4.

@juanpicado
Copy link
Member

juanpicado commented Dec 22, 2018

If anyone is willing to contribute on this, a next step would be

We need to find the way to keep flow and typescript for a while until the migration is done.

https://github.com/Microsoft/TypeScript-Babel-Starter

Update (January 2019)

We just created a custom babel preset, that allow us to switch to Flow or Typescript using Babel 7, more details on this repo.

https://github.com/verdaccio/babel-preset

Update (July 2019)

Migration is in progress in this PR #1374 , core project has been already converted, in progress unit testing.

@juanpicado juanpicado pinned this issue Dec 22, 2018
@stackdumper stackdumper changed the title Switch to TypeScript? Switch to TypeScript Dec 22, 2018
@juanpicado
Copy link
Member

juanpicado commented Jan 27, 2019

Working on this by steps

@juanpicado juanpicado self-assigned this Jan 27, 2019
juanpicado added a commit to verdaccio/local-storage that referenced this issue Feb 1, 2019
@juanpicado
Copy link
Member

juanpicado commented Feb 3, 2019

✔️ List

  • ✔️ Migrated all direct dependencies to Typescript (verdaccio-audit, verdaccio-htpasswd, @verdaccio/local-storage and @verdaccio/streams )
  • ✔️ Created Types for Typescript
  • ✔️ Using migrated dependencies on branch4.x

This is the most I can do. We cannot migrate the main project yet until 4.x is merged into master otherwise we will block new contributions. After release, I will complete the remaining part.

WIP -> https://github.com/verdaccio/verdaccio/tree/refactor-typescript

@juanpicado
Copy link
Member

Update: Migration is done, waiting possible code reviews. #1374

Development 4.x automation moved this from In progress to Done Jul 16, 2019
@juanpicado juanpicado unpinned this issue Jul 16, 2019
sergiohgz pushed a commit to verdaccio/monorepo that referenced this issue Aug 13, 2019
sergiohgz pushed a commit to verdaccio/monorepo that referenced this issue Aug 14, 2019
@lock
Copy link

lock bot commented Oct 14, 2019

🤖This thread has been automatically locked 🔒 since there has not been any recent activity after it was closed.
We lock tickets after 90 days with the idea to encourage you to open a ticket with new fresh data and to provide you better feedback 🤝and better visibility 👀.
If you consider, you can attach this ticket 📨 to the new one as a reference for better context.
Thanks for being a part of the Verdaccio community! 💘

@lock lock bot added the outdated label Oct 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants