This repository has been archived by the owner on Jan 16, 2022. It is now read-only.
feat: added zh-CN translations to the UI #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added zh-CN translations to the UI
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
==========================================
- Coverage 85.47% 85.22% -0.26%
==========================================
Files 141 141
Lines 1019 1022 +3
Branches 210 210
==========================================
Hits 871 871
- Misses 122 125 +3
Partials 26 26
|
|
Awesome 👏🏻! |
juanpicado
previously approved these changes
Mar 30, 2020
|
@JackyChan great job 👌 Please before we merge it, could you please also add the locale https://github.com/verdaccio/ui/blob/master/src/App/load-dayjs-locale.ts After that we are good to go :) |
Ok, it's done. |
|
Kudos, SonarCloud Quality Gate passed!
|
priscilawebdev
approved these changes
Apr 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added zh-CN translations to the UI
Type:
The following has been addressed in the PR:
Description: