Skip to content

Commit

Permalink
fix: update fields for abbreviated manifest (#4674)
Browse files Browse the repository at this point in the history
  • Loading branch information
mbtools committed Jun 13, 2024
1 parent b270f7a commit de6ff5c
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 3 deletions.
6 changes: 6 additions & 0 deletions .changeset/rich-shrimps-check.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@verdaccio/types': patch
'@verdaccio/store': patch
---

fix: update fields for abbreviated manifest
12 changes: 11 additions & 1 deletion packages/core/types/src/manifest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ export interface Version {
optionalDependencies?: Dependencies;
peerDependenciesMeta?: PeerDependenciesMeta;
bundleDependencies?: Dependencies;
acceptDependencies?: Dependencies;
keywords?: string | string[];
nodeVersion?: string;
_id: string;
Expand Down Expand Up @@ -180,6 +181,7 @@ export interface FullRemoteManifest {
versions: Versions;
/** store owners of this package */
maintainers?: Author[];
contributors?: Author[];
/** store the latest readme **/
readme?: string;
/** store star assigned to this packages by users */
Expand Down Expand Up @@ -224,14 +226,22 @@ export type AbbreviatedVersion = Pick<
Version,
| 'name'
| 'version'
| 'description'
| 'dependencies'
| 'devDependencies'
| 'bin'
| 'dist'
| 'engines'
| 'funding'
| 'peerDependencies'
| 'cpu'
| 'deprecated'
| 'directories'
| 'hasInstallScript'
| 'optionalDependencies'
| 'os'
| 'peerDependenciesMeta'
| 'acceptDependencies'
| '_hasShrinkwrap'
>;

export interface AbbreviatedVersions {
Expand Down
5 changes: 4 additions & 1 deletion packages/store/src/storage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,6 @@ class Storage {
const _version_abbreviated = {
name: _version.name,
version: _version.version,
description: _version.description,
deprecated: _version.deprecated,
bin: _version.bin,
dist: _version.dist,
Expand All @@ -536,6 +535,10 @@ class Storage {
peerDependencies: _version.peerDependencies,
optionalDependencies: _version.optionalDependencies,
bundleDependencies: _version.bundleDependencies,
cpu: _version.cpu,
os: _version.os,
peerDependenciesMeta: _version.peerDependenciesMeta,
acceptDependencies: _version.acceptDependencies,
// npm cli specifics
_hasShrinkwrap: _version._hasShrinkwrap,
hasInstallScript: _version.hasInstallScript,
Expand Down
5 changes: 4 additions & 1 deletion packages/store/test/storage.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1894,7 +1894,6 @@ describe('storage', () => {
expect(Object.keys(version)).toEqual([
'name',
'version',
'description',
'deprecated',
'bin',
'dist',
Expand All @@ -1906,6 +1905,10 @@ describe('storage', () => {
'peerDependencies',
'optionalDependencies',
'bundleDependencies',
'cpu',
'os',
'peerDependenciesMeta',
'acceptDependencies',
'_hasShrinkwrap',
'hasInstallScript',
]);
Expand Down

0 comments on commit de6ff5c

Please sign in to comment.