Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display package peer deps #1144

Merged
merged 5 commits into from
Dec 3, 2018
Merged

feat: display package peer deps #1144

merged 5 commits into from
Dec 3, 2018

Conversation

stephanebachelier
Copy link
Contributor

Type: feature

The following has been addressed in the PR:

  • Unit tests are included in the PR

Description:

Append Peer dependencies on PackageSidebar.

@ayusharma
Copy link
Member

@juanpicado Let's keep this PR on 4.x, anyway, we can not merge in master. @stephanebachelier we are doing refactoring in webui so most of the things will change.

@juanpicado
Copy link
Member

Let's talk about this in person later on @ayusharma. This is a potential conflict. I think should be con based on 4.x branch. @stephanebachelier thanks for the PR please I'll keep you in touch what we decided how to handle this.

@stephanebachelier
Copy link
Contributor Author

@juanpicado @ayusharma I can rebase (redo?) my work for the 4.x branch.

@ayusharma
Copy link
Member

@stephanebachelier I'll let you asap know after discussing it with @juanpicado 😀

@ayusharma
Copy link
Member

@stephanebachelier I had a discussion with @juanpicado . We'll review it and ship it with 3.x

ayusharma
ayusharma approved these changes Dec 2, 2018
View reviewed changes
Copy link
Member

@ayusharma ayusharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) Nice work 🚀

juanpicado
juanpicado approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@juanpicado juanpicado added this to the 3.x.x milestone Dec 3, 2018
@juanpicado juanpicado merged commit 9b52b1d into verdaccio:master Dec 3, 2018
@juanpicado juanpicado mentioned this pull request Dec 4, 2018
Closed
@juanpicado
Copy link
Member

Congrats @stephanebachelier 🥇
released on verdaccio@3.9.0

@lock
Copy link

lock bot commented Mar 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juanpicado juanpicado juanpicado approved these changes

@ayusharma ayusharma ayusharma approved these changes

Assignees
No one assigned
Labels
topic: feature request topic: web
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephanebachelier @ayusharma @juanpicado