-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: theme as plugin #1252
feat: theme as plugin #1252
Conversation
# Conflicts: # src/webui/components/Help/index.js # src/webui/pages/version/index.js # test/unit/webui/components/__snapshots__/help.spec.js.snap
# Conflicts: # package.json # src/webui/components/Dependencies/index.js # src/webui/components/DetailContainer/index.js # src/webui/components/NotFound/index.js # src/webui/components/Versions/index.js # yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🤖This thread has been automatically locked 🔒 since there has not been any recent activity after it was closed. |
Type: feature
Request:
We want to allow custom themes imported via dependencies, this might be the beginning of the theme as a plugin.
Solution:
This PR moves the UI to a separated (https://github.com/verdaccio/ui) repository under the name of
@verdaccio/ui-theme
as default dependency. To override the custom theme you need to add the following to the configuration file.The plugin must follow the format according to the previous example
verdaccio-theme-{dark}
.If is need it, the properties will be passed as options as any other plugin, this might help to create more dynamic themes.
fix #357
follow up of #1215