Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: theme as plugin #1252

Merged
merged 14 commits into from
Apr 6, 2019
Merged

feat: theme as plugin #1252

merged 14 commits into from
Apr 6, 2019

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented Mar 12, 2019

Type: feature

Request:

We want to allow custom themes imported via dependencies, this might be the beginning of the theme as a plugin.

Solution:

This PR moves the UI to a separated (https://github.com/verdaccio/ui) repository under the name of @verdaccio/ui-theme as default dependency. To override the custom theme you need to add the following to the configuration file.

theme:
  dark:
    option1: 1
    option2: 2

The plugin must follow the format according to the previous example verdaccio-theme-{dark}.

⚠️ The prefix is strict and the plugin only will be resolved whether the name starts with verdaccio-theme-.

If is need it, the properties will be passed as options as any other plugin, this might help to create more dynamic themes.

fix #357

follow up of #1215

# Conflicts:
#	src/webui/components/Help/index.js
#	src/webui/pages/version/index.js
#	test/unit/webui/components/__snapshots__/help.spec.js.snap
@juanpicado juanpicado added this to Blocked in Development 4.x Apr 2, 2019
# Conflicts:
#	package.json
#	src/webui/components/Dependencies/index.js
#	src/webui/components/DetailContainer/index.js
#	src/webui/components/NotFound/index.js
#	src/webui/components/Versions/index.js
#	yarn.lock
@juanpicado juanpicado mentioned this pull request Apr 5, 2019
3 tasks
@juanpicado juanpicado changed the title feat: allow custom themes feat: theme as a dependency Apr 5, 2019
@juanpicado juanpicado changed the title feat: theme as a dependency feat: UI as a dependency Apr 5, 2019
@juanpicado juanpicado changed the title feat: UI as a dependency feat: theme as plugin Apr 5, 2019
@juanpicado juanpicado modified the milestones: 4.2.0, 4.0.0 Apr 5, 2019
@juanpicado juanpicado moved this from Blocked to In progress in Development 4.x Apr 5, 2019
juanpicado added a commit to verdaccio/website that referenced this pull request Apr 6, 2019
Copy link
Collaborator

@verdacciobot verdacciobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juanpicado juanpicado merged commit c3c6202 into master Apr 6, 2019
Development 4.x automation moved this from In progress to Done Apr 6, 2019
@juanpicado juanpicado deleted the fix-357-3 branch April 6, 2019 06:35
@lock
Copy link

lock bot commented Jun 29, 2019

🤖This thread has been automatically locked 🔒 since there has not been any recent activity after it was closed.
We lock tickets after 90 days with the idea to encourage you to open a ticket with new fresh data and to provide you better feedback 🤝and better visibility 👀.
If you consider, can attach this ticket 📨to the new one as a reference for better context.
Thanks for being a part of the Verdaccio community! 💘

@lock lock bot locked as resolved and limited conversation to collaborators Jun 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Allow use custom theme
2 participants