Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in code from https://github.com/fl4re/sinopia #15

Closed
czardoz opened this issue Apr 26, 2016 · 5 comments
Closed

Merge in code from https://github.com/fl4re/sinopia #15

czardoz opened this issue Apr 26, 2016 · 5 comments
Labels

Comments

@czardoz
Copy link

czardoz commented Apr 26, 2016

A few very important commits have gone into that fork, perhaps it would make sense to merge them here as well.

@trentearl
Copy link
Contributor

Awesome, i'll try to look into this when I have time. @czardoz is there anything you know of that is especially important?

@czardoz
Copy link
Author

czardoz commented Apr 26, 2016

Yes, fl4re/sinopia@50e5baf

It ensures that the Web UI does not show packages if the user is not signed in. But almost all the 31 commits in that fork are useful in one way or another :)

@trentearl trentearl mentioned this issue Apr 30, 2016
@trentearl
Copy link
Contributor

@czardoz I created merge request #17 can you review this?

@czardoz
Copy link
Author

czardoz commented May 3, 2016

@trentearl Totally unsure about the code base, so I doubt my review is of much help. I can confirm that the all important commit of protecting the search endpoint is indeed present.

I'll try actually running your branch later this week, and report back. :)

@lock
Copy link

lock bot commented May 30, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label May 30, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants