Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In search results you can see names of private packages #107

Closed
darkowic opened this issue Dec 27, 2016 · 14 comments
Closed

In search results you can see names of private packages #107

darkowic opened this issue Dec 27, 2016 · 14 comments

Comments

@darkowic
Copy link

darkowic commented Dec 27, 2016

I have private and not visible package with name starting with d

verdaccio_no_packages

But when I start typing in search as a anonymous user I can see it.
verdaccio_search

@juanpicado
Copy link
Member

Can you elaborate this a bit more?

@darkowic
Copy link
Author

There was an error in my post - the package name starts with 'd'.

ok example - Package is called e.g. demo. It is private package. When you type d in search on page, the demo package will be listed even though it should not be there (couse is private)

@silkentrance
Copy link
Contributor

See also #15 which might already provide a fix for this issue.

@juanpicado juanpicado modified the milestones: 2.1.2, 2.1.3 Mar 9, 2017
@juanpicado juanpicado added this to Help Wanted in Roadmap Mar 18, 2017
@juanpicado juanpicado modified the milestones: 2.2.1, Future Jun 10, 2017
@juanpicado juanpicado added this to Backlog in Next Patch Release Jun 10, 2017
@juanpicado juanpicado moved this from Backlog to In Progress in Next Patch Release Jun 23, 2017
@juanpicado
Copy link
Member

@darkowic Could you share the configuration of your demo?

@juanpicado juanpicado moved this from In Progress to Feedback Need it in Next Patch Release Jun 26, 2017
@darkowic
Copy link
Author

@juanpicado What do you mean the configuration? The js package json config or the verdaccio config?

@silkentrance
Copy link
Contributor

@darkowic does this occur after you restarted the verdaccio server or after that you published a new private package to the running verdaccio server?

@juanpicado
Copy link
Member

@darkowic verdaccio config file. I need to know how to reproduce it.

@AvailCat
Copy link
Member

Which version of verdaccio? this issue should fixed after 2.1.5

@darkowic
Copy link
Author

$ verdaccio --version
2.1.0
#
# This is the default config file. It allows all users to do anything,
# so don't use it on production systems.
#
# Look here for more config file examples:
# https://github.com/verdaccio/verdaccio/tree/master/conf
#

url_prefix: something

# path to a directory with all packages
storage: ./storage

auth:
  htpasswd:
    file: ./htpasswd
    # Maximum amount of users allowed to register, defaults to "+inf".
    # You can set this to -1 to disable registration.
    max_users: -1

# a list of other known repositories we can talk to
uplinks:
  npmjs:
    url: https://registry.npmjs.org/

packages:
  'demo*': # here is something else but it should not affect anything
    access: $authenticated
    publish: $authenticated

  '**':
    # allow all users (including non-authenticated users) to read and
    # publish all packages
    #
    # you can specify usernames/groupnames (depending on your auth plugin)
    # and three keywords: "$all", "$anonymous", "$authenticated"
    access: $authenticated

    # allow all known users to publish packages
    # (anyone can register by default, remember?)
    publish: $authenticated

    # if package is not available locally, proxy requests to 'npmjs' registry
    proxy: npmjs

# log settings
logs:
  - {type: stdout, format: pretty, level: http}

The package I host here is called e.g. demo-something.

@silkentrance I don't remember if it occurs with first publishing. But, I was restarting the server many times and it is still reproducible

@AvailCat
Copy link
Member

@darkowic So you should update your verdaccio, latest version is 2.2.1

@darkowic
Copy link
Author

darkowic commented Jun 27, 2017 via email

@AvailCat
Copy link
Member

I can confirm it's fixed in latest version, have a try

@darkowic
Copy link
Author

darkowic commented Jun 27, 2017 via email

@juanpicado juanpicado moved this from Feedback Need it to Done in Next Patch Release Jun 27, 2017
@AvailCat AvailCat moved this from Help Wanted to Done in Roadmap Sep 17, 2017
@lock
Copy link

lock bot commented Aug 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Aug 17, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

4 participants