Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update docs to support minimum node v10 #1753

Merged
merged 1 commit into from
Mar 14, 2020
Merged

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented Mar 14, 2020

Type: fix

The following has been addressed in the PR:

  • There is a related issue?
  • Unit or Functional tests are included in the PR

Description:

At v4.5.0 we shipped some security releases, one of them is JSDOM https://github.com/jsdom/jsdom/releases/tag/16.0.0 and only supports Node.js v10

Node v8 is out of maintenance so we don't consider this a breaking change.

Expect this if you try to use Node v8.

npm WARN notsup Unsupported engine for verdaccio@4.5.1: wanted: {"node":">=10","npm":">=5"} (current: {"node":"8.17.0","npm":"6.13.4"})

Errors on Node v8

⚠️ If you are using Node v8 and you have this issue, have on mind you can use only verdaccio@4.4.4 or less if you cannot upgrade to Node v10.

➜ verdaccio
/Users/user/.nvm/versions/node/v8.17.0/lib/node_modules/verdaccio/node_modules/jsdom/lib/jsdom/living/helpers/dates-and-times.js:235
  } catch {
          ^

SyntaxError: Unexpected token {
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Module._compile (module.js:617:28)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/user/.nvm/versions/node/v8.17.0/lib/node_modules/verdaccio/node_modules/jsdom/lib/jsdom/living/helpers/form-controls.js:18:5)

At v4.5.0 we shipped some security releases, one of them is JSDOM https://github.com/jsdom/jsdom/releases/tag/16.0.0 and only supports Node.js v10

Node v8 is out of maintenance so we don't consider this a breaking change.
@codecov
Copy link

codecov bot commented Mar 14, 2020

Codecov Report

Merging #1753 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1753   +/-   ##
=======================================
  Coverage   83.47%   83.47%           
=======================================
  Files          48       48           
  Lines        2530     2530           
  Branches      592      592           
=======================================
  Hits         2112     2112           
  Misses        413      413           
  Partials        5        5           

@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@juanpicado juanpicado added this to the 4.x.x milestone Mar 14, 2020
@juanpicado juanpicado merged commit 17c3324 into master Mar 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-drop-node8 branch March 14, 2020 07:28
@lock
Copy link

lock bot commented Mar 27, 2020

🤖This thread has been automatically locked 🔒 since there has not been any recent activity after it was closed.
We lock tickets after 90 days with the idea to encourage you to open a ticket with new fresh data and to provide you better feedback 🤝and better visibility 👀.
If you consider, you can attach this ticket 📨 to the new one as a reference for better context.
Thanks for being a part of the Verdaccio community! 💘

@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants