Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate 4.x yarn 1 to yarn 2 #1962

Merged
merged 1 commit into from
Oct 11, 2020
Merged

feat: migrate 4.x yarn 1 to yarn 2 #1962

merged 1 commit into from
Oct 11, 2020

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented Oct 11, 2020

master branch uses yarn 1, time to move to yarn 2 to benefit of new features.

note: 5.x uses pnpm and no plan to change it.

No big changes since I've not enabled pnp https://yarnpkg.com/configuration/yarnrc#nodeLinker

  • update Dockerfile
  • strict dependencies
  • update release scripts
  • update CI scripts
  • remove Node 8 from CI (yarn 2 does work >=v10). Note: we still support v8.
nodeLinker: node-modules

@juanpicado juanpicado force-pushed the migrate-yarn2 branch 3 times, most recently from 11ed80a to 14bb703 Compare October 11, 2020 14:48
@juanpicado juanpicado force-pushed the migrate-yarn2 branch 6 times, most recently from ddf31f3 to cc87898 Compare October 11, 2020 16:23
@juanpicado juanpicado marked this pull request as ready for review October 11, 2020 16:24
verdacciobot
verdacciobot previously approved these changes Oct 11, 2020
@juanpicado juanpicado added this to the Future milestone Oct 11, 2020
@juanpicado juanpicado merged commit 1ece11c into master Oct 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the migrate-yarn2 branch October 11, 2020 17:06
@soulchild
Copy link

This just broke our automatic Verdaccio build to include custom plugins. Our Dockerfile looks similar to this:

FROM verdaccio/verdaccio:4

RUN yarn add --no-lockfile --production=true verdaccio-ldap verdaccio-aws-s3-storage

yarn2 removed the options --no-lockfile and --production. Running yarn add without them unnecessarily installs half of npm. I suppose this is because the final image of the multi-stage build of Verdaccio correctly doesn't include the devDependencies (used only in the builder stage) which are now installed again when we run yarn add.

I know next to nothing about yarn, so can you suggest a way around this?

@juanpicado
Copy link
Member Author

Could you use previous tag in the meantime I research ?

@soulchild
Copy link

Yes, I already did that. 😄 Thanks for looking into it!

@juanpicado
Copy link
Member Author

Could you create a ticket otherwise I will forget, please 🙏 add some examples.

@soulchild
Copy link

Thanks, @juanpicado! #2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants