Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__VERDACCIO_BASENAME_UI_OPTIONS is missing version field #3671

Closed
kanoshin opened this issue Mar 9, 2023 · 1 comment · Fixed by #3674
Closed

__VERDACCIO_BASENAME_UI_OPTIONS is missing version field #3671

kanoshin opened this issue Mar 9, 2023 · 1 comment · Fixed by #3674
Labels
5.x branch topic: ui v.next bugs
Milestone
Next

Comments

@kanoshin
Copy link

kanoshin commented Mar 9, 2023

Your Environment

  • verdaccio version: 5.22.1
  • os: [linux]
  • platform: [docker]

Describe the bug

After updating from 5.14.0 to 5.22.1, I noticed that verdaccio version is no longer displayed in the website footer. And __VERDACCIO_BASENAME_UI_OPTIONS global variable doesn't have a version field as well.

To Reproduce

Just run verdaccio via Docker image v5.22.1.

Expected behavior

Version is displayed in the footer and in the __VERDACCIO_BASENAME_UI_OPTIONS.
@juanpicado
Copy link
Member

Thanks, yeah probably 😅 I screw up something else again ... refactoring not easy need more test 😬

@juanpicado juanpicado added this to the v6 release milestone Mar 11, 2023
@juanpicado juanpicado linked a pull request Mar 11, 2023 that will close this issue
fix: missing version on footer #3674
Merged
@juanpicado juanpicado mentioned this issue Mar 18, 2023
Merged
juanpicado added a commit that referenced this issue Mar 18, 2023
@juanpicado
fix: add missing version on footer #3671
b85ba99
@juanpicado juanpicado modified the milestones: v6 release, Next major Aug 20, 2023
@GTVolk GTVolk mentioned this issue Nov 28, 2023
Open
@GTVolk GTVolk mentioned this issue Mar 22, 2024
Open
@GTVolk GTVolk mentioned this issue May 13, 2024
Open
@GTVolk GTVolk mentioned this issue May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5.x branch topic: ui v.next bugs
Projects
None yet
Milestone
Next
Development

Successfully merging a pull request may close this issue.

fix: missing version on footer verdaccio/verdaccio
2 participants
@juanpicado @kanoshin