Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally suppress or override instructions in web user interface #593

Closed
SheetJSDev opened this issue Feb 25, 2018 · 1 comment
Closed

Optionally suppress or override instructions in web user interface #593

SheetJSDev opened this issue Feb 25, 2018 · 1 comment
Labels
help wanted issue_needs_triage outdated PR-Welcome topic: feature request
Projects
New Web UI Roadmap [v4]
Milestone
3.x

Comments

@SheetJSDev
Copy link
Contributor

The npm client supports scope-level registries wherein requests for modules in different scopes are directed to different registries. For example:

npm login --registry=http://server1/ --scope=@scope1 
npm login --registry=http://server2/ --scope=@scope2

A request for @scope1/module will hit the first registry. A request for @scope2/module will hit the second module. A request for an unscoped module or a module under any other scope will hit the default registry.

This enables a verdaccio workflow wherein private modules are pushed under one scope and the server has no uplink. The default instructions shown in the banner aren't appropriate in cases like this.

To reduce confusion, it would be nice to be able to suppress or supply different header content. There are a few ways to address this problem, sorted by presumed difficulty:

  1. add an option to hide banner:
web:
  banner: false
  1. add an option to specify a scope:
web:
  scope: "@scope1"
  1. allow custom html for the header
@juanpicado juanpicado added this to To do in New Web UI Roadmap [v4] via automation Jun 4, 2018
@coolsp coolsp mentioned this issue Jul 29, 2018
Merged
@juanpicado juanpicado added this to the 3.x.x milestone Jul 30, 2018
paulbrimicombe pushed a commit to paulbrimicombe/verdaccio that referenced this issue Aug 23, 2018
@coolsp @paulbrimicombe
feat: adds option to set scope in webui instructions header
aba2cf8 
If you're using this registry for a specific module scope, specify that scope to set it in the webui instructions header e.g. npm set @coolsp:registry http://localhost:4873.
Added as webui.scope option in .yaml.
> Note: in .yaml, escape @ with \\@.

See also feature request verdaccio#593.
paulbrimicombe pushed a commit to paulbrimicombe/verdaccio that referenced this issue Aug 23, 2018
@coolsp @paulbrimicombe
feat: adds option to set scope in webui instructions header
981fe17 
If you're using this registry for a specific module scope, specify that scope to set it in the webui instructions header e.g. npm set @coolsp:registry http://localhost:4873.
Added as webui.scope option in .yaml.
> Note: in .yaml, escape @ with \\@.

See also feature request verdaccio#593.
Update unit test for added scope
paulbrimicombe pushed a commit to paulbrimicombe/verdaccio that referenced this issue Aug 23, 2018
@coolsp @paulbrimicombe
feat: adds option to set scope in webui instructions header
1cfe780 
If you're using this registry for a specific module scope, specify that scope to set it in the webui instructions header e.g. npm set @coolsp:registry http://localhost:4873.
Added as webui.scope option in .yaml.
> Note: in .yaml, escape @ with \\@.

See also feature request verdaccio#593.

Removed changes to website/translated_docs and website/versioned_docs
And update docs/web.md and config.md
paulbrimicombe pushed a commit to paulbrimicombe/verdaccio that referenced this issue Aug 23, 2018
@coolsp @paulbrimicombe
feat: adds option to set scope in webui instructions header
3321fd6 
If you're using this registry for a specific module scope, specify that scope to set it in the webui instructions header e.g. npm set @coolsp:registry http://localhost:4873.
Added as webui.scope option in .yaml.
> Note: in .yaml, escape @ with \\@.

See also feature request verdaccio#593.

Corrected typo myscopy --> myscope
paulbrimicombe pushed a commit to paulbrimicombe/verdaccio that referenced this issue Aug 23, 2018
@coolsp @paulbrimicombe
feat: adds option to set scope in webui instructions header
c491560 
If you're using this registry for a specific module scope, specify that scope to set it in the webui instructions header e.g. npm set @coolsp:registry http://localhost:4873.
Added as webui.scope option in .yaml.
> Note: in .yaml, escape @ with \\@.

See also feature request verdaccio#593.
paulbrimicombe pushed a commit to paulbrimicombe/verdaccio that referenced this issue Aug 23, 2018
@coolsp @paulbrimicombe
feat: adds option to set scope in webui instructions header
b25ffa1 
If you're using this registry for a specific module scope, specify that scope to set it in the webui instructions header e.g. npm set @coolsp:registry http://localhost:4873.
Added as webui.scope option in .yaml.
> Note: in .yaml, escape @ with \\@.

See also feature request verdaccio#593.
Update unit test for added scope
paulbrimicombe pushed a commit to paulbrimicombe/verdaccio that referenced this issue Aug 23, 2018
@coolsp @paulbrimicombe
feat: adds option to set scope in webui instructions header
7fc5614 
If you're using this registry for a specific module scope, specify that scope to set it in the webui instructions header e.g. npm set @coolsp:registry http://localhost:4873.
Added as webui.scope option in .yaml.
> Note: in .yaml, escape @ with \\@.

See also feature request verdaccio#593.

Removed changes to website/translated_docs and website/versioned_docs
And update docs/web.md and config.md
paulbrimicombe pushed a commit to paulbrimicombe/verdaccio that referenced this issue Aug 23, 2018
@coolsp @paulbrimicombe
feat: adds option to set scope in webui instructions header
e2f78af 
If you're using this registry for a specific module scope, specify that scope to set it in the webui instructions header e.g. npm set @coolsp:registry http://localhost:4873.
Added as webui.scope option in .yaml.
> Note: in .yaml, escape @ with \\@.

See also feature request verdaccio#593.

Corrected typo myscopy --> myscope
New Web UI Roadmap [v4] automation moved this from To do to Done Sep 24, 2018
@SheetJSDev SheetJSDev mentioned this issue Oct 7, 2018
Closed
@lock
Copy link

lock bot commented Apr 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted issue_needs_triage outdated PR-Welcome topic: feature request
Projects
No open projects
New Web UI Roadmap [v4]
  
Done
Milestone
3.x
Development

No branches or pull requests
2 participants
@juanpicado @SheetJSDev