Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add banner plugin to webpack to tag bundle with current version #784

Closed
ayusharma opened this issue Jun 24, 2018 · 6 comments · Fixed by #786
Closed

Add banner plugin to webpack to tag bundle with current version #784

ayusharma opened this issue Jun 24, 2018 · 6 comments · Fixed by #786
Labels
good first issue outdated topic: web
Projects
New Web UI Roadmap [v4]

Comments

@ayusharma
Copy link
Member

ayusharma commented Jun 24, 2018 •
edited
Loading

Currently, There is no build/version information in the webpack bundle. It would be very helpful to find this information.

https://webpack.js.org/plugins/banner-plugin/
@ayusharma ayusharma created this issue from a note in New Web UI Roadmap [v4] (To do) Jun 24, 2018
@satyamyadav
Copy link
Contributor

satyamyadav commented Jun 24, 2018 •
edited
Loading

Hi @ayusharma, I will work on this, will be sharing a banner template.

@satyamyadav
Copy link
Contributor

Sharing a template generated with webpack banner plugin, please suggest if it needs to be containing more information or need to remove some. Also should it include timestamp ?

/*!
 * 
 *     Hash: 3ca0f911a9154709a7fc 
 *     Chunkhash: ff808475141b55913510
 *     Name: vendors 
 *     File: 0.style.b86c5878ee2935af83e9.css
 *     Generated on: 1529907426327
 *     Package: verdaccio
 *     Version: v3.2.0
 *     Author: Alex Kocharin <alex@kocharin.ru>
 *     Description: Private npm repository server
 *     Source: git://github.com/verdaccio/verdaccio
 *     License: MIT
 *     
 */

@juanpicado
Copy link
Member

I'd remove the following.

 *     Author: Alex Kocharin <alex@kocharin.ru>
 *     Description: Private npm repository server
 *     Source: git://github.com/verdaccio/verdaccio
 *     Hash: 3ca0f911a9154709a7fc 
 *     Chunkhash: ff808475141b55913510
 *     File: 0.style.b86c5878ee2935af83e9.css

@ayusharma
Copy link
Member Author

@juanpicado All looks good. @satyamyadav waiting for a PR ❤️

satyamyadav pushed a commit to satyamyadav/verdaccio that referenced this issue Jun 25, 2018
@innosatyam
fix: adds webpack banner plugin to tag bundles with version (verdacci…
c65d503 
…o#784)
satyamyadav pushed a commit to satyamyadav/verdaccio that referenced this issue Jun 25, 2018
@innosatyam
fix: adds webpack banner plugin to tag bundles with version (verdacci…
833007a 
…o#784)
@satyamyadav satyamyadav mentioned this issue Jun 25, 2018
Merged
@satyamyadav
Copy link
Contributor

@ayusharma Created PR #786 , please review the changes.

satyamyadav pushed a commit to satyamyadav/verdaccio that referenced this issue Jun 25, 2018
@innosatyam
fix: adds webpack banner plugin to tag bundles with version (verdacci…
2392206 
…o#784)

refactor: updates let to const in generateBanner module
@ayusharma ayusharma moved this from To do to In progress in New Web UI Roadmap [v4] Jun 25, 2018
satyamyadav pushed a commit to satyamyadav/verdaccio that referenced this issue Jun 26, 2018
@innosatyam
fix: adds webpack banner plugin to tag bundles with version (verdacci…
fcbcfa9 
…o#784)

refactor: updates let to const in generateBanner module

refactor: adds getPackageJson module to get vlues from package.json
satyamyadav pushed a commit to satyamyadav/verdaccio that referenced this issue Jun 28, 2018
@innosatyam
fix: adds webpack banner plugin to tag bundles with version (verdacci…
8e19c6c 
…o#784)

refactor: updates let to const in generateBanner module

refactor: adds getPackageJson module to get vlues from package.json

refactor: adds jsdoc comments in getPackageJson module
satyamyadav pushed a commit to satyamyadav/verdaccio that referenced this issue Jun 29, 2018
@innosatyam
fix: adds webpack banner plugin to tag bundles with version (verdacci…
dac28d3 
…o#784)

refactor: updates let to const in generateBanner module

refactor: adds getPackageJson module to get vlues from package.json

refactor: adds jsdoc comments in getPackageJson module
New Web UI Roadmap [v4] automation moved this from In progress to Done Jun 29, 2018
ayusharma pushed a commit that referenced this issue Jun 29, 2018
Merge pull request #786 from satyamyadav/add-banner-plugin-to-webpack
f4a4f02 
fix: adds webpack banner plugin to tag bundles with version (#784)
@lock
Copy link

lock bot commented Jan 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Jan 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue outdated topic: web
Projects
No open projects
New Web UI Roadmap [v4]
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adds webpack banner plugin to tag bundles with version (#784) satyamyadav/verdaccio
3 participants
@juanpicado @satyamyadav @ayusharma