Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: atob not support unicode strings #840

Closed
calledT opened this issue Jul 23, 2018 · 3 comments
Closed

webui: atob not support unicode strings #840

calledT opened this issue Jul 23, 2018 · 3 comments

Comments

@calledT
Copy link

calledT commented Jul 23, 2018

Describe the bug
I use verdaccio-ldap for auth and the token payload has unicode strings. webui use atob decode payload will throw error.

payload = JSON.parse(atob(payload));

I just replace atob with https://github.com/dankogai/js-base64 Base64.decode manually and it work well.

@ayusharma
Copy link
Member

atob has the problem with Unicode. Read it here https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/Base64_encoding_and_decoding

Also, Implement the solution described in the above article.

@ayusharma ayusharma removed their assignment Jul 24, 2018
@juanpicado juanpicado added this to the 3.x.x milestone Jul 25, 2018
@juanpicado juanpicado added this to To do in Roadmap via automation Jul 25, 2018
@ayusharma ayusharma self-assigned this Jul 26, 2018
ayusharma added a commit that referenced this issue Jul 26, 2018
…strings

feat: adds base64 support in webui token (#840)
Roadmap automation moved this from To do to Done Jul 26, 2018
@juanpicado
Copy link
Member

shipped verdaccio@3.4.0

paulbrimicombe pushed a commit to paulbrimicombe/verdaccio that referenced this issue Aug 23, 2018
@lock
Copy link

lock bot commented Feb 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Feb 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Roadmap
  
Done
Development

No branches or pull requests

3 participants