Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI change details page issue of package readme #959

Closed
aremishevsky opened this issue Aug 27, 2018 · 6 comments · Fixed by #960
Closed

UI change details page issue of package readme #959

aremishevsky opened this issue Aug 27, 2018 · 6 comments · Fixed by #960

Comments

@aremishevsky
Copy link

aremishevsky commented Aug 27, 2018

Describe the bug

The readme of the package is not loading on change package using current package redirection.

To Reproduce
Steps to reproduce the behavior:

  1. Go to [your-npm-registry]/#/detail/react (react package is just an example. The same issue exists for any package)
  2. Click on 'prop-types' for example in sidebar dependencies
  3. Please note that URL was changed, sidebar information was loaded, but the readme block is still from previous package ("react" in our case). But the H1 element was changed.

After the full reload of the page we have a correct readme but once you go to new dependencie - we have the same issue

It can be reproduced only starting from the 3.6.0 version.

Expected behavior
The readme of the package should be loaded.

Screenshots
_local__npm_registry_1

_local__npm_registry_2

@ayusharma
Copy link
Member

@aremishevsky I'll check as soon as possible.

@aremishevsky
Copy link
Author

@juanpicado @ayusharma thanks for so fast progress in this bugfix.

Please let me know once the new version would be published.

@juanpicado
Copy link
Member

@aremishevsky GitHub will send you an ✉️ after the release is done. 👍 , but, pretty soon.

@juanpicado juanpicado added this to the 3.x.x milestone Aug 28, 2018
@ayusharma
Copy link
Member

@aremishevsky Please install verdaccio@3.7.1

@coolsp
Copy link
Member

coolsp commented Aug 28, 2018

Pulled the latest docker image and can confirm this is fixed.

@lock
Copy link

lock bot commented Mar 16, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Mar 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants