feat: add support for profile cli command #392 (change password) #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it allows to update password npm profile set password - display current profile npm profile get https://docs.npmjs.com/cli/profile
on npm by defaul is min 7 characters, this might be configurable in the future.
juanpicado
changed the title
sergiohgz
previously requested changes
Oct 2, 2018
src/api/endpoint/api/user.js
Outdated
| if (validatePassword(password) === false) { | ||
| /* eslint new-cap:off */ | ||
| return next(ErrorCode.getCode(HTTP_STATUS.BAD_REQUEST, API_ERROR.PASSWORD_SHORT())); | ||
| /* eslint new-cap:off */ |
There was a problem hiding this comment.
I think you tried to re-enable new-cap rule, but cp was wrong 😂
This was referenced Oct 2, 2018
|
This still needs more test, functional and increase coverage. But the basic functionality works. |
|
It's ready for CR, I'll defer the functional test for a future PR, I need to upgrade first |
Merged
ayusharma
approved these changes
Oct 12, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feat
The following has been addressed in the PR:
Description:
https://docs.npmjs.com/cli/profile
Resolves #392
Refers to #913
ℹ️ Currently only some plugins (verdaccio-htpasswd) implement the
changePasswordfeature, thus, if you are using an authentification plugin that does not support this feature, I'd suggest open a request in their repositories.