Add support for multiple notification endpoints to existing webhook s…

[ryan-codingintrigue]

This extends the existing webhook system to allow for posting to multiple endpoints based off the package name being published.

The current global webhook system remains untouched to allow for backwards compatibility - it will still run alongside any webhooks defined in a collection under the notify node.

It also adds regular expression support to the existing global webhook.

[juanpicado]

It fails here https://travis-ci.org/verdaccio/verdaccio/jobs/190535973#L1302

[ryan-codingintrigue]

Re-ran the Travis build and seems to have passed checks. Must have been a transient error

[juanpicado]

@ryan-codingintrigue Could you help me to fix the conflicts? I think I screwed up your PR fixing another bug.

[ryan-codingintrigue]

Thanks @juanpicado - I think that should be correct now. Apologies, I've never re-based a fork on Github before so this is quite new to me!

[juanpicado]

Could you standardize code styling? eg: if ( instead if(. The same below for for below. In part is my fault because eslint strict styling hasn't been worked out yet.

[ryan-codingintrigue]

@juanpicado Thanks a lot, sorry for the delay on this. Migrated these changes to ES6 syntax and fixed those code styling issues.

[juanpicado]

thanks @ryan-codingintrigue 👍 again, I'll merge it today.

[juanpicado]

I was doing unit testing for it and I noticed in Node without full ES6 support fails if you use packagePatternFlags. So I'll remove support for packagePatternFlags until Node 4 is dropped.

TypeError: Cannot supply flags when constructing one RegExp from another
    at new RegExp (native)

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp

Starting with ECMAScript 6, new RegExp(/ab+c/, 'i') no longer throws a TypeError ("can't supply flags when constructing one RegExp from another") when the first argument is a RegExp and the second flags argument is present. A new RegExp from the arguments is created instead.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

[juanpicado]

@ryan-codingintrigue node 4 was dropped long time ago, https://github.com/verdaccio/verdaccio/blob/master/src/lib/notify.js#L9
I think we can reenable this.