Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chore): Included provision to show up local environment information #1365

Merged
merged 7 commits into from Jun 30, 2019
Merged

feat(chore): Included provision to show up local environment information #1365

merged 7 commits into from Jun 30, 2019

Conversation

jamesgeorge007
Copy link
Member

@jamesgeorge007 jamesgeorge007 commented Jun 29, 2019

Type:
feature

Description:
Included a new option which shows up the local environment information, useful while submitting bug reports.

Fixes #1364

verdaccio --info

Environment Info:

  System:
    OS: Linux 4.18 Ubuntu 18.10 (Cosmic Cuttlefish)
    CPU: (2) x64 Intel(R) Pentium(R) CPU G2020 @ 2.90GHz
  Binaries:
    Node: 8.11.4 - /usr/bin/node
    Yarn: 1.13.0 - /usr/local/bin/yarn
    npm: 6.9.2 - /usr/local/bin/npm
  Virtualization:
    Docker: 18.06.1 - /usr/bin/docker
  Browsers:
    Chrome: 72.0.3626.81
    Firefox: 65.0
  npmGlobalPackages:
    verdaccio: 4.0.4

@jamesgeorge007
Copy link
Member Author

cc @juanpicado

@jamesgeorge007 jamesgeorge007 changed the base branch from master to 4.1.x June 29, 2019 13:43
package.json Outdated Show resolved Hide resolved
src/lib/cli.js Outdated Show resolved Hide resolved
src/lib/cli.js Outdated Show resolved Hide resolved
Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, we are almost there :-) small changes.

@juanpicado juanpicado mentioned this pull request Jun 30, 2019
@jamesgeorge007
Copy link
Member Author

cc @juanpicado

src/lib/cli.js Outdated Show resolved Hide resolved
src/lib/cli.js Outdated Show resolved Hide resolved
src/lib/cli.js Outdated Show resolved Hide resolved
@juanpicado
Copy link
Member

One more thing to be done, we need update documentation, otherwise nobody will be aware of this 👨‍💻 This file https://github.com/verdaccio/website/blob/master/docs/cli.md needs to be updated. Be aware of only that file is need to be updated (https://github.com/verdaccio/website/blob/master/CONTRIBUTING.md#source-code-website) the translated one are auto generated. I'd add a link to https://www.npmjs.com/package/envinfo so users are aware what expect of the new CLI command.

Thanks again for this contribution 💯

@jamesgeorge007
Copy link
Member Author

One more thing to be done, we need update documentation, otherwise nobody will be aware of this This file https://github.com/verdaccio/website/blob/master/docs/cli.md needs to be updated. Be aware of only that file is need to be updated (https://github.com/verdaccio/website/blob/master/CONTRIBUTING.md#source-code-website) the translated one are auto generated. I'd add a link to https://www.npmjs.com/package/envinfo so users are aware what expect of the new CLI command.

Thanks again for this contribution

@juanpicado Kindly have a look at 159

handle async behaviour
src/lib/cli.js Outdated Show resolved Hide resolved
@jamesgeorge007
Copy link
Member Author

cc @juanpicado

Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@juanpicado
Copy link
Member

juanpicado commented Jun 30, 2019

Thanks @jamesgeorge007 , this is gonna be really really really useful 💯

Welcome to Verdaccio world 🌍

@juanpicado juanpicado merged commit eb6bf51 into verdaccio:4.1.x Jun 30, 2019
@jamesgeorge007 jamesgeorge007 deleted the feat/envinfo branch July 1, 2019 08:33
@jamesgeorge007
Copy link
Member Author

@juanpicado Have a look at Mevn-CLI. Love to know your thoughts 👏

@juanpicado
Copy link
Member

It looks pretty nice and clean code :-) your CLi is much nicer than ours https://github.com/madlabsinc/mevn-cli/blob/master/src/cli.js
If you want to have a chat, you can find me at Discord.

@jamesgeorge007
Copy link
Member Author

jamesgeorge007 commented Jul 1, 2019 via email

@jamesgeorge007
Copy link
Member Author

jamesgeorge007 commented Jul 1, 2019 via email

@jamesgeorge007
Copy link
Member Author

@juanpicado Guess it's the right time to update the Issue template regarding verdaccio --info.
Shall I shoot up a PR targeting the 4.1.x branch?

@DanielRuf
Copy link
Contributor

Sounds good.

@juanpicado
Copy link
Member

Sorry which issue ?

@lock
Copy link

lock bot commented Jul 12, 2019

🤖This thread has been automatically locked 🔒 since there has not been any recent activity after it was closed.
We lock tickets after 90 days with the idea to encourage you to open a ticket with new fresh data and to provide you better feedback 🤝and better visibility 👀.
If you consider, can attach this ticket 📨to the new one as a reference for better context.
Thanks for being a part of the Verdaccio community! 💘

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2019
@juanpicado
Copy link
Member

@jamesgeorge007 first issue using version argument #1392 🎉

@juanpicado juanpicado added this to the 4.1.0 milestone Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants