Fix search feature #163
Merged
Fix search feature #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The https module allows for an intermediate certificate in the options. It was somehow missed. Adding it back since I had a certificate that included an intermediate certificate.
- Check permission in search API - Fix author's name not show in search result
Since NodeJS 7, call async api without callback is deprecared.
Added 'access' check to search route Handle failed Ajax search request as 'No result'
|
Thanks @Meeeeow I'll check asap , awesome |
juanpicado
reviewed
Apr 21, 2017
| @@ -133,7 +133,11 @@ module.exports = function(config, auth, storage) { | |||
| var getData = function(i) { | |||
| storage.get_package(results[i].ref, function(err, entry) { | |||
| if (!err && entry) { | |||
| packages.push(entry.versions[entry['dist-tags'].latest]) | |||
| auth.allow_access(entry.name, req.remote_user, function(err, allowed) { // TODO: This may cause performance issue? | |||
There was a problem hiding this comment.
Reply of #161 (comment)
@Meeeeow
About the can('access'), yeah you are right. No way to use the middleware. Perhaps you update allowed as is_allowed, to be consistent with the middleware.
About the performance, I haven't tested with thousands of packages, but, it worth to try in the future and see what's happen.
|
Aside of the small review, LGTM 👍 |
Closed
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick from fl4re's fork:
I'm not familiar with git and just destroyed my repo and lost some changes... So i deleted my GitHub repo and reopen a new PR here, sorry for this.
@juanpicado