fix: escaped slash in namespaced packages #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…packages' into fix/escaped-slash-in-namespaced-packages
* chore: fix start web issue * chore: use custom action for changeset this is temporary while I find the way to skip create github releases for alpha * chore: format as separated workflow (#2194) Co-authored-by: Juan Picado <juanpicado19@gmail.com>
juanpicado
previously approved these changes
Apr 24, 2021
|
could you add a changeset https://github.com/verdaccio/verdaccio/blob/master/CONTRIBUTING.md#adding-a-changeset ? Then we are good to merge. |
|
One more thing, this won't be available on Verdaccio 5 after merge this, if you want to also be avilable there, then you would need a new PR over 5.x branch. |
* chore: fix start web issue * chore: use custom action for changeset this is temporary while I find the way to skip create github releases for alpha * chore: format as separated workflow (#2194) Co-authored-by: Juan Picado <juanpicado19@gmail.com>
…n-namespaced-packages
|
Welcome to verdaccio world @amitgilad3 🚀 |
|
thanks!!!!! @juanpicado , i hope to contribute as much as possible to this amazing product!!! |
|
@juanpicado Has this been merged in v5? |
|
Nop, only master by far (for v5 should be on 5.x branch) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to fix the escaped slash and make it more like the response from npm registry i removed the encodeScopedUri function which replaces in scoped url the / with %2f making in compatible with the response from npm
close #1778 #1777