Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor User Interface #220

Merged
merged 59 commits into from Jul 18, 2017
Merged

Refactor User Interface #220

merged 59 commits into from Jul 18, 2017

Conversation

juanpicado
Copy link
Member

@juanpicado juanpicado commented Jun 17, 2017

Type: feature

The following has been addressed in the PR:

Description:

Roadmap: #221

Resolves

@codecov
Copy link

codecov bot commented Jun 17, 2017

Codecov Report

Merging #220 into master will increase coverage by 0.55%.
The diff coverage is 74.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage    82.2%   82.75%   +0.55%     
==========================================
  Files          23       32       +9     
  Lines        2242     2285      +43     
==========================================
+ Hits         1843     1891      +48     
+ Misses        399      394       -5
Impacted Files Coverage Δ
src/lib/storage.js 85.77% <ø> (ø)
src/plugins/htpasswd/utils.js 77.14% <ø> (ø)
src/lib/status-cats.js 100% <ø> (ø)
src/lib/storage/local/local-fs.js 83.56% <ø> (ø)
src/lib/config.js 97.72% <ø> (ø)
src/plugins/htpasswd/crypt3.js 69.23% <ø> (ø)
src/lib/storage/local/local-data.js 100% <ø> (ø)
src/plugins/htpasswd/index.js 92.42% <ø> (ø)
src/lib/storage/streams.js 100% <ø> (ø)
src/lib/notify.js 97.67% <ø> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a817ec...3a80227. Read the comment docs.

@AvailCat
Copy link
Member

I will try implement login feature, then merge it

@codecov-io
Copy link

codecov-io commented Jul 9, 2017

Codecov Report

Merging #220 into master will increase coverage by 2.28%.
The diff coverage is 74.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   76.63%   78.92%   +2.28%     
==========================================
  Files           5       19      +14     
  Lines         612     1039     +427     
==========================================
+ Hits          469      820     +351     
- Misses        143      219      +76
Impacted Files Coverage Δ
src/lib/config.js 97.72% <ø> (ø)
src/lib/notify.js 97.67% <ø> (ø)
src/api/endpoint/index.js 100% <100%> (ø)
index.js 100% <100%> (ø) ⬆️
src/lib/cli.js 68% <100%> (ø)
src/lib/logger.js 72.72% <100%> (ø)
src/config/env.js 100% <100%> (ø)
src/api/endpoint/api/ping.js 100% <100%> (ø)
src/api/web/api.js 38.88% <38.88%> (ø)
src/lib/auth.js 70.93% <42.1%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8df59b...b3e8937. Read the comment docs.

@juanpicado juanpicado force-pushed the refactor-ui branch 2 times, most recently from 20d7500 to 1a13190 Compare July 13, 2017 06:01
@juanpicado
Copy link
Member Author

juanpicado commented Jul 13, 2017

Some topics are missing here:

  • Dockerfile and Webpack: We need to define how the Dockerfile will handle the pre-build step
  • StASS Lint (https://www.npmjs.com/package/stylelint)
  • CSS must be minified
  • dot files (.babelrc and any related with webpack should be in root)
  • Unit test for readme endpoint is disabled
  • .babelrc We shouldn't use stages, stages change time on time that might breaks the build.

@juanpicado
Copy link
Member Author

This PR can be tested under npm install verdaccio@beta -g beta tag.

@juanpicado juanpicado force-pushed the refactor-ui branch 2 times, most recently from 51cca34 to 6cb9ade Compare July 16, 2017 07:26
@AvailCat AvailCat moved this from WIP to Done in 2.3.x (UI Refactoring) Jul 17, 2017
@juanpicado
Copy link
Member Author

Great job @Meeeeow

@juanpicado juanpicado merged commit 855ace7 into master Jul 18, 2017
@juanpicado juanpicado deleted the refactor-ui branch July 18, 2017 20:01
@juanpicado juanpicado mentioned this pull request Jul 19, 2017
6 tasks
@juanpicado juanpicado changed the title Refactor ui - WIP Refactor User Interface Jul 22, 2017
@lock
Copy link

lock bot commented May 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants