Fixed adding the verdaccio user into the group

[markpeterfejes]

Type: bug

The following has been addressed in the PR: There was a typo in the command creating the verdaccio user

Description: This exceptionally huge change makes it possible to use the image without chowning the whole volume in an init-container as mentioned in #238. :)

To be able to use it just make a change in your deployment file, add this to your PodSpec (101 is the verdaccio group id)

"securityContext": {
    "fsGroup": 101
}                        

Resolves #238

BUT
There is still a problem while trying to use the image like this:
docker run -it -v ~/test:/verdaccio/storage verdaccio/verdaccio:latest

I believe that it's a problem on Docker side.

[codecov]

Codecov Report

Merging #241 into master will increase coverage by 1.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   80.48%   82.42%   +1.93%     
==========================================
  Files          17       24       +7     
  Lines        1471     2304     +833     
==========================================
+ Hits         1184     1899     +715     
- Misses        287      405     +118

Impacted Files	Coverage Δ
lib/storage/local/local-storage.js	81.66% <0%> (ø)
lib/plugins/htpasswd/utils.js	77.14% <0%> (ø)
lib/plugins/htpasswd/index.js	92.42% <0%> (ø)
lib/storage/local/local-fs.js	83.56% <0%> (ø)
lib/storage/local/local-data.js	100% <0%> (ø)
lib/storage/streams.js	100% <0%> (ø)
lib/storage/up-storage.js	90.47% <0%> (ø)
lib/plugins/htpasswd/crypt3.js	69.23% <0%> (+2.56%)	⬆️
lib/logger.js	76.62% <0%> (+3.89%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f59b0d...109d80a. Read the comment docs.

[juanpicado]

How this will impact the nonkubernetes users?

[markpeterfejes]

This change should not impact them anyhow. They wasn't able to use the image before this. They either have to run this without persistence, or have to set the permissions for the attached folder on the host.

[juanpicado]

Now I see it. I'm still a 🐋er newbie 😄 . Thanks for the explanation.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.