use light version of syntax highlighter #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried something similar but that broke my UI, it works for you? |
|
Never mind, you are the author of |
|
@juanpicado yeah the problem was you were attempting to import /highlight instead of /light and weren't using registerLanguage. no problem! |
|
Thanks again @conorhastings could you rebase? |
conorhastings
force-pushed
the
use-react-synax-highlighter-light
branch
from
bfe4aba
to
d1b30a5
Compare
|
@juanpicado done |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following has been addressed in the PR:
Uses light version of react syntax highlighter to remove 820kb from bundle size for client
before:
after: