Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added e2e example test #3779

Merged
merged 1 commit into from
Apr 30, 2023
Merged

added e2e example test #3779

merged 1 commit into from
Apr 30, 2023

Conversation

rluvaton
Copy link
Contributor

added simplified example that test the build and installation of the package

@rluvaton
Copy link
Contributor Author

Hey man @juanpicado do you know why the build is failing?

Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! Thanks good to see u again !

@juanpicado
Copy link
Member

Hey man @juanpicado do you know why the build is failing?

Yes is my fault, I need to fix the build for deploy the website but I was in 🏝️ but :) just finished probably fix this week.

@juanpicado juanpicado merged commit 489f036 into verdaccio:master Apr 30, 2023
37 of 38 checks passed
@rluvaton rluvaton deleted the patch-1 branch May 1, 2023 14:58
@rluvaton
Copy link
Contributor Author

rluvaton commented May 1, 2023

Awesome ! Thanks good to see u again !

Great to see you too

@rluvaton
Copy link
Contributor Author

rluvaton commented Jul 2, 2023

Hey @juanpicado, it seems like the website did not deploy yet, is there anything I can do to help?

@juanpicado
Copy link
Member

Mmmm, it deploys every day automatically, 🤔 all green

https://github.com/verdaccio/verdaccio/actions/workflows/website.yml

Screenshot 2023-07-03 at 13 22 59

@@ -96,3 +96,4 @@ Via CLI:
- [e2e-ci-example-gh-actions](https://github.com/juanpicado/e2e-ci-example-gh-actions)
- [verdaccio-end-to-end-tests](https://github.com/juanpicado/verdaccio-end-to-end-tests)
- [verdaccio-fork](https://github.com/juanpicado/verdaccio-fork)
- [simplified e2e testing using verdaccio](https://github.com/rluvaton/e2e-verdaccio-example)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rluvaton ahhh, you updated main docs, which is deployed at 6.x https://verdaccio.org/docs/next/e2e for 5.x you need to update same file in the versioned folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, created a new pr

@rluvaton rluvaton mentioned this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants