Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display labels for engine versions #4051

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix: display labels for engine versions #4051

merged 1 commit into from
Oct 6, 2023

Conversation

mbtools
Copy link
Collaborator

@mbtools mbtools commented Oct 3, 2023 •
edited

Fixes the following issues with the engine component (in the sidebar):

  • Spelling of "NODE JS"
  • Display of "node version" under "NPM Version"
  • Incorrect title for "Yarn Version" and "Pnpm Version"

image

Corrections:

  • Changed "NODE JS" to the official "Node.js" spelling
  • Display the correct npm version for the "Npm Version" box
  • Added proper titles for "Yarn Version" and "Pnpm Version"

image

PS: It shows as "Node.Js" instead of "Node.js" because of text-transform: capitalize; CSS. Not sure if you want to correct this.

juanpicado
juanpicado approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it :) thanks

@juanpicado juanpicado merged commit 02ba426 into verdaccio:master Oct 6, 2023
47 of 49 checks passed
@mbtools mbtools deleted the ui_engines branch October 6, 2023 14:49
@juanpicado juanpicado mentioned this pull request Oct 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpicado juanpicado juanpicado approved these changes

Assignees
No one assigned
Labels
topic: ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbtools @juanpicado