Webui tests

[ayusharma]

Type: feature / unit test

The following has been addressed in the PR:

• There is a related issue
• Unit or Functional tests are included in the PR

Description:

Resolves #415

[juanpicado]

@ayusharma we have a conflict here jest.config.js

[ayusharma]

resolving conflict.

[juanpicado]

Does not babel do it out of the box already? babel-plugin-syntax-async-functions . I think after all merges we have to review the policy of presets

[juanpicado]

typo --> gloabl

[juanpicado]

Small changes, but the test are failing, Do you have any idea?

[juanpicado]

Well, I did not manage to fix it. Something is really bad with the babel configuration. We have to find a solution all test are broken now

[juanpicado]

Issues:

The first one is on .babelrc configuration file.

• "es2015" preset is not needed it. "es2015-node4" does already include all you need.
• "transform-class-properties" does break the functional test. You don't need it.

     "test": {
-      "presets": [ "es2015-node4", "es2015", "flow", "react"],
+      "presets": [ "es2015-node4", "flow", "react"],
       "plugins": [
         "transform-class-properties",
         "transform-object-rest-spread",
-        "transform-class-properties",
         "syntax-async-functions"
       ]
     },

The second issue is on jest.config.js.

If you map storage

    'storage': '<rootDir>/test/webui/components/__mocks__/storage.js',

causes

    TypeError: Storage is not a constructor

I think you have to use something less generic than storage. I'd rename all those modules as eg: uiStorage to avoid future conflics.

There are more issues, this is what I found by far.

[juanpicado]

If you update the circleci.yaml removing Node4, you are done here 👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.