Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adduser error message grammar #4586

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

Tobbe
Copy link
Contributor

@Tobbe Tobbe commented Apr 22, 2024

Just fixing a tiny grammatical error in an error message 馃檪

Thanks a lot for all the work you put into Verdaccio 馃檹

Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good but please include changeset please read contribution guidelines

@Tobbe
Copy link
Contributor Author

Tobbe commented Apr 22, 2024

please read contribution guidelines

Sorry about that! I've added a changeset. The guidelines also say I need to include a test. Is that applicable here? If it is, can you please point me to where I might add those tests? Thanks

@juanpicado
Copy link
Member

No test :) this case is just debug code.

@juanpicado juanpicado merged commit 4dc62a8 into verdaccio:master Apr 23, 2024
35 checks passed
@Tobbe
Copy link
Contributor Author

Tobbe commented Apr 23, 2024

Woohoo 馃帀 Thanks for merging 馃榿

@Tobbe Tobbe deleted the tobbe-adduser-debug-grammar branch April 23, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants