Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-88] rename to Verdaccio instead of Sinopia #93

Merged
merged 4 commits into from Feb 5, 2017

Conversation

kgrubb
Copy link

@kgrubb kgrubb commented Nov 7, 2016

Based on issue #88

CHANGES:

  • Aside from a few locations (such as links to issues & the history), 'sinopia' has been renamed to 'verdaccio'.

  • The .travis.yml has been updated to run on officially supported node versions (I can switch this back if needed).

@Nighthawk22
Copy link

This will be a breaking change. No old db will be working without renaming and also no sinopia plugin

@kgrubb
Copy link
Author

kgrubb commented Nov 9, 2016

Right, I'll add some sinopia plugin compatibility into this then. What about db data, though? Is that simply changing the .verdaccio-db.json back to .sinopia-db.json?

@kgrubb
Copy link
Author

kgrubb commented Nov 9, 2016

Alright, sinopia plugin compatibility seems fine again. I think this should also fix issue #64 as well now.

@kgrubb
Copy link
Author

kgrubb commented Feb 5, 2017

Is it required to get everything passing on node version 0.12, even though it is no longer a supported release? Tests pass on 4, 6, & 7, but not for 0.12. I'd prefer to drop 0.12 from the travis testing, but I'm unsure of how many people are still using 0.12 to deploy/use verdaccio.

@juanpicado
Copy link
Member

juanpicado commented Feb 5, 2017

Actually 0.12 was dropped recently, minimum is >=4. Please remove 0.12.

@juanpicado juanpicado self-requested a review February 5, 2017 06:27
.travis.yml Outdated
@@ -1,8 +1,9 @@
language: node_js
node_js:
- '0.12'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove this part in order to merge.

.travis.yml Outdated
- '4'
- '6'
- '7'
- 'iojs'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove this part in order to merge.

@juanpicado
Copy link
Member

Looks good to me, please fix the issues and I'll merge

@juanpicado juanpicado merged commit b765460 into verdaccio:master Feb 5, 2017
@juanpicado
Copy link
Member

Thanks @kgrubb 👍

@lock
Copy link

lock bot commented May 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants