Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split entities, prepositions as predicates, add implicits, fix bug #31

Merged
merged 9 commits into from
Sep 12, 2017
Merged

Split entities, prepositions as predicates, add implicits, fix bug #31

merged 9 commits into from
Sep 12, 2017

Conversation

gabrielStanovsky
Copy link
Collaborator

Changes to adhere to V1 structure:

  • Splitting entities according to OKR conventions
  • Prepositions as predicates
  • Adding implicit relations (bare predicate is IMPLICIT and the index -1)

Fixing bugs:

@gabrielStanovsky
Copy link
Collaborator Author

gabrielStanovsky commented Sep 11, 2017 •
edited

Performance improved for entity mention:

Predicate mentions(F1): 0.218
Entity mentions(F1): 0.420
Predicate coreference: MUC=0.153, B^3=0.601, CEAF_C=0.171, MELA=0.308
Entity coreference: MUC=0.249, B^3=0.714, CEAF_C=0.303, MELA=0.422

Low performance may be related to #30
@rachelvov's been getting much better for entity mention in V2 metrics.

kleinay
kleinay approved these changes Sep 12, 2017
View reviewed changes
Copy link
Collaborator

@kleinay kleinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

examples/raw_sentences
# Horrified by national news headlines this evening that the Boy Scouts USA covered up allegations of child abuse for years.
# # Issue #16
# Boy Scouts files on alleged sex abusers to be released -
The new ambassador said that soliders from Israel won the prize.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why commenting out?

@kleinay kleinay merged commit 60e4a9e into vered1986:props Sep 12, 2017
@OriShapira OriShapira changed the title Split entities, propositions as predicates, add implicits, fix bug Split entities, prepositions as predicates, add implicits, fix bug Sep 17, 2017
@kleinay kleinay mentioned this pull request Sep 17, 2017
Closed
@gabrielStanovsky gabrielStanovsky mentioned this pull request Sep 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleinay kleinay kleinay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabrielStanovsky @kleinay