Added exclude node_modules to webpack.config's babel-loader. #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webpack update is great. Thank you for it. I want to make one recommendation, but please let me know if I'm misunderstanding, as I'm still learning:
Starting from commit 300317b you introduced
webpack.config.babel.js
to manage the bundling andbabel-loader
. I believe it's common practice to eitherexclude: /node_modules/
orinclude
specific files or folders to avoid having babel-loader go through the whole node_modules folder. I believe this affects chapters 7-12.I made the change below and noticed that it decreased the run time of
gulp
taskmain
from 15 seconds to 2.5 seconds when excluding /node_modules/ in chapter 11. The resultingclient-bundle.js
is slightly different but seems to work just the same.The bolded line below shows the change to 6 files (
webpack.config.babel.js
in chapter 7-12):