Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the package less of a monolith #4

Open
parente opened this issue Feb 27, 2018 · 2 comments
Open

Make the package less of a monolith #4

parente opened this issue Feb 27, 2018 · 2 comments

Comments

@parente
Copy link
Contributor

parente commented Feb 27, 2018

Quick note from the Jupyter call today

  • @mpacer mentioned that a simple update to setup.py could make the tool runnable via nbconvert
  • I mentioned that breaking up the rather monolithic exporter + preprocessor setup that we have right now to make parts reusable independently (if there's value in that). The gotcha is that REST API calls to Confluence have to be made at various phases of the process to image version lookup, page version lookup, etc.
@parente
Copy link
Contributor Author

parente commented Feb 27, 2018

Delayed submit and I crossed the streams a bit with #3. Thanks @mpacer!

@danizen
Copy link
Contributor

danizen commented Sep 5, 2019

The gotcha is that REST API calls to Confluence have to be made at various phases of the process to do image version lookup

This at least is not true in my environment. For issue #30, I simply removed the lookup of the URL and use the attachment filename as in <ri:attachment ri:filename="{{ ... }}"/>. That means that there are parts of the pre-processor that may not be necessary.

Since the other mechanism for doing confluence attachments is needed, I suggest that the template path be also a traitlet, so that people can use different templates for their own confluence.

This was referenced Sep 5, 2019
mikemac-n0 pushed a commit to mikemac-n0/nbconflux that referenced this issue Nov 28, 2022
in the nbconvert upgrade, the template file was moved to a seperate folder,
but the location of the template file was not updated in the manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants