Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/4 implement profile page #22

Merged
merged 10 commits into from
Dec 23, 2022
Merged

Feature/4 implement profile page #22

merged 10 commits into from
Dec 23, 2022

Conversation

aurelticot
Copy link
Contributor

Closes #4

@aurelticot aurelticot self-assigned this Dec 23, 2022
@aurelticot aurelticot marked this pull request as ready for review December 23, 2022 03:53
nick-verida
nick-verida approved these changes Dec 23, 2022
View reviewed changes
Copy link

@nick-verida nick-verida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/components/organisms/CollectiblesSection.tsx Outdated Show resolved Hide resolved
src/components/organisms/CollectiblesSection.tsx Show resolved Hide resolved
src/components/organisms/CustomLinksSection.tsx Outdated Show resolved Hide resolved
src/lib/constants/chains.ts Show resolved Hide resolved
@nick-verida
Copy link

NFTs are showing different sizes (desktop Firefox). Need to constrain them?
image

This doesn't need to be fixed before merging but should be fixed.

Good for you to merge.

@aurelticot
Copy link
Contributor Author

NFTs are showing different sizes (desktop Firefox).

Ah, the aspect-ratio I used may not be supported, I'll create a dedicated ticket.
Need to test on different browsers.

@aurelticot aurelticot mentioned this pull request Dec 23, 2022
Closed
@aurelticot aurelticot merged commit 8947f6a into develop Dec 23, 2022
@aurelticot aurelticot deleted the feature/4-implement-profile-page branch December 23, 2022 05:11
@aurelticot aurelticot linked an issue Jan 9, 2023 that may be closed by this pull request
Implement Profile page #4
Closed
@aurelticot aurelticot added this to the alpha milestone Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-verida nick-verida nick-verida approved these changes

Assignees

@aurelticot aurelticot

Labels
None yet
Projects
None yet
Milestone
alpha
Development

Successfully merging this pull request may close these issues.

Implement Profile page
2 participants
@aurelticot @nick-verida