Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit 3e6bd62751939bb22ff160ef401b35ce9e49b029 doesn't build #253

Closed
ghost opened this issue Jun 15, 2021 · 4 comments
Closed

Commit 3e6bd62751939bb22ff160ef401b35ce9e49b029 doesn't build #253

ghost opened this issue Jun 15, 2021 · 4 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Jun 15, 2021

(cpu_p18) roblim1@skylake06:~/repos/verificarlo> make -j8
make  all-recursive
make[1]: Entering directory '/gpfs/jlse-fs0/users/roblim1/repos/verificarlo'
Making all in src/
make[2]: Entering directory '/gpfs/jlse-fs0/users/roblim1/repos/verificarlo/src'
Making all in common
make[3]: Entering directory '/gpfs/jlse-fs0/users/roblim1/repos/verificarlo/src/common'
make[3]: *** No rule to make target 'vfc_probes_f.mod', needed by 'all-am'.  Stop.
make[3]: *** Waiting for unfinished jobs....
  CC       libvfc_probes_la-vfc_hashmap.lo
  CC       libvfc_probes_la-vfc_probes.lo
  CC       libvprec_tools_la-vprec_tools.lo
  CC       libtinymt64_la-tinymt64.lo
  CC       libvfc_hashmap_la-vfc_hashmap.lo
make[3]: Leaving directory '/gpfs/jlse-fs0/users/roblim1/repos/verificarlo/src/common'
make[2]: *** [Makefile:431: all-recursive] Error 1
make[2]: Leaving directory '/gpfs/jlse-fs0/users/roblim1/repos/verificarlo/src'
make[1]: *** [Makefile:516: all-recursive] Error 1
make[1]: Leaving directory '/gpfs/jlse-fs0/users/roblim1/repos/verificarlo'
make: *** [Makefile:403: all] Error 2
@pablooliveira
Copy link
Member

@PurplePachyderm could you please have a look ?
On our autobuilder 3e6bd62 is building but maybe there is an issue on some machines with the fortran modules rules that were added.

@PurplePachyderm
Copy link
Member

Sure, this might have something to do with the rules to build the Fortran interface not being ignored correctly when flang support is disabled.

@PurplePachyderm
Copy link
Member

It seems like the rule to install the Fortan header was not inside the if BUILD_FLANG clause in src/common/Makefile.am. When testing the install without flang support, I probably forgot to make clean so I didn't run into the issue since the file was already there. I'll open a PR that should fix the issue and add a small correction to the code of vfc_ci.

PurplePachyderm added a commit to PurplePachyderm/verificarlo that referenced this issue Jun 15, 2021
Correctly put the Fortran rules inside the if BUILD_FLANG clause so that
vfc_probes_f.mod won't cause issue if the support is disabled.

Also add a minor correction to the vfc_ci test command to make it easier
to pass arguments to the test executables.
PurplePachyderm added a commit to PurplePachyderm/verificarlo that referenced this issue Jun 15, 2021
Correctly ignores the rules for the Fortran interface when flang support
is disaled.

Also add a small correction to the code of the vfc_ci test command to
make it easier to correctly pass arguments to the test executables.
@PurplePachyderm
Copy link
Member

Just opened the PR (#255). This should solve the issue but we should probably wait for someone else to confirm before closing it.

PurplePachyderm added a commit that referenced this issue Jun 15, 2021
@ghost ghost closed this as completed Jun 15, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants