It should not be necessary to call VerifyICSharpCodeDecompiler.Enable

[tom-englert]

it should just work out of the box.

[SimonCropp]

this is problematic for a couple of reasons

• it is desirable to be able to Verify ICSharpCode directly. ie i would prefer to have to remember to call VerifyICSharpCodeDecompiler.Enable once ather than remember that i always need to pass in a custom type that exists in Verify.ICSharpCode.Decompiler just to get the side effect of a hidden VerifyICSharpCodeDecompiler.Enable.
• there is an ecosystem of extensions that all use the "enable in module init" pattern

[tom-englert]

Actually I don't see why this is a problem.

• When you pass in a custom type to Verify (e.g. await Verify(new TypeToDisassemble(file, type))), it requires that this custom type is registered.
• If the type is not registered, there is no warning or error, it's just not working at all, which is very annoying.

So why not ensure that if you use such a custom type, it simply ensures that it's registered with Verify.

It does not break any other use case, just makes it more seamless to use. You can still can call Enable by your own, if you like, and everything else will work the same, no matter if the types are registered or not.

Since this pattern is used in other extensions, too, maybe there should be a more global solution, like e.g. in Serilog where they look for such registration methods via reflection in all loaded assemblies?

[SimonCropp]

but await Verify(new AssemblyToDisassemble(file)) requires people to always remember to use AssemblyToDisassemble every single time they verify an assembly. ie this wont work

using var file = new PEFile(assembly2Path);
await Verify(file);

[tom-englert]

So we make every days life harder, just to optimize one very rare edge case?

[SimonCropp]

"passing the actual type from the underlying library" is not a rare edge case. it is how the majority of verification happens

[SimonCropp]

currently undocumented, but u can call VerifierSettings.InitializePlugins(); which will do a dll scan and call initialize on all verify plugins