-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It should not be necessary to call VerifyICSharpCodeDecompiler.Enable #400
Comments
this is problematic for a couple of reasons
|
Actually I don't see why this is a problem.
So why not ensure that if you use such a custom type, it simply ensures that it's registered with Verify. It does not break any other use case, just makes it more seamless to use. You can still can call Since this pattern is used in other extensions, too, maybe there should be a more global solution, like e.g. in Serilog where they look for such registration methods via reflection in all loaded assemblies? |
but
|
So we make every days life harder, just to optimize one very rare edge case? |
"passing the actual type from the underlying library" is not a rare edge case. it is how the majority of verification happens |
currently undocumented, but u can call |
it should just work out of the box.
The text was updated successfully, but these errors were encountered: