-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
self.avg vs. (self.elapsed/self.index) #34
Comments
Actually, I am sorry, this is not a bug against upstream (i tested with 1.2-7.fc24). With upstream ETA works correctly.
It is no longer: avg simple moving average time per item (in seconds) (as stated in docs) but instead it seems to be: items per second. So probably just README.md update is needed and this can be closed. Thx. |
Ouch, you claim semantics of API changed? |
FWIW, according to Fedora bug: |
Yes, Fedora-Rawhide version works. |
So can I merge PR/35 and close this? |
Fine by me but that #35 request is unneeded if you return to the original semantics :). Anyway, this can be closed. |
This should be fixed now |
Shouldn't self.avg be (roughly) equal to self.elapsed/self.index? In my test (file uploading) it comes out differently:
1.578591763973236e-08 (self.avg) vs. 7.149365691934405e-08 (self.elapsed/self.index)
Eta is then not correct (less than actual).
Thanks!
The text was updated successfully, but these errors were encountered: