Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen the minimum channel width and related metric pass characteristics for small circuits #2613

Open
vaughnbetz opened this issue Jun 13, 2024 · 1 comment
Assignees

Comments

@vaughnbetz
Copy link
Contributor

We get a reasonable number of spurious QoR failures in CI on the small benchmarks in things like arithmetic/figure8.
We should loosen the relevant QoR metrics by making new small pass requirements and pointing at them. As circuits fail, we can point the relevant tests at this set of looser criteria instead of constantly updating golden.

This is better practice than having spurious failures that people learn to update -- that takes longer, and teaches a bad habit of expecting some failures.

@amin1377
Copy link
Contributor

This is implemented in PR #2608.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants