Feat/support eslint 9 (#400)

* feat(update): fight with tsc * feat(sugg): update fixes * chore(cleanup): cleaned up rules
vitest-dev · Mar 25, 2024 · 4079285 · 4079285
1 parent bbe0130
commit 4079285
Show file tree

Hide file tree

Showing 15 changed files with 36 additions and 21 deletions.
diff --git a/README.md b/README.md
@@ -134,7 +134,7 @@ If you're using this feature, you should also enabled `typecheck` in the setting
 🌐 Set in the `all` configuration.\
 ✅ Set in the `recommended` configuration.\
 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).\
-💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).\
+💡 Manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).\
 ❌ Deprecated.
 
 | Name                                                                                                                     | Description                                                              | 💼 | ⚠️ | 🔧 | 💡 | ❌  |

diff --git a/docs/rules/no-done-callback.md b/docs/rules/no-done-callback.md
@@ -4,7 +4,7 @@
 
 ⚠️ This rule _warns_ in the 🌐 `all` config.
 
-💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).
+💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 
 <!-- end auto-generated rule header -->
 

diff --git a/docs/rules/prefer-equality-matcher.md b/docs/rules/prefer-equality-matcher.md
@@ -2,7 +2,7 @@
 
 ⚠️ This rule _warns_ in the 🌐 `all` config.
 
-💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).
+💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 
 <!-- end auto-generated rule header -->
 

diff --git a/docs/rules/prefer-expect-assertions.md b/docs/rules/prefer-expect-assertions.md
@@ -2,7 +2,7 @@
 
 ⚠️ This rule _warns_ in the 🌐 `all` config.
 
-💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).
+💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 
 <!-- end auto-generated rule header -->
 

diff --git a/docs/rules/prefer-strict-equal.md b/docs/rules/prefer-strict-equal.md
@@ -2,7 +2,7 @@
 
 ⚠️ This rule _warns_ in the 🌐 `all` config.
 
-💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).
+💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 
 <!-- end auto-generated rule header -->
 

diff --git a/src/rules/consistent-test-it.ts b/src/rules/consistent-test-it.ts
@@ -56,7 +56,7 @@ export default createEslintRule<
         fixable: 'code',
         docs: {
             description: 'Prefer test or it but not both',
-            recommended: 'warn'
+            recommended: 'strict'
         },
         messages: {
             consistentMethod:
@@ -69,9 +69,11 @@ export default createEslintRule<
                 type: 'object',
                 properties: {
                     fn: {
+                        type: 'string',
                         enum: [TestCaseName.test, TestCaseName.it]
                     },
                     withinDescribe: {
+                        type: 'string',
                         enum: [TestCaseName.test, TestCaseName.it]
                     }
                 },

diff --git a/src/rules/max-expects.ts b/src/rules/max-expects.ts
@@ -15,7 +15,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
     meta: {
         docs: {
             requiresTypeChecking: false,
-            recommended: 'error',
+            recommended: 'strict',
             description: 'Enforce a maximum number of expect per test'
         },
         messages: {

diff --git a/src/rules/max-nested-describe.ts b/src/rules/max-nested-describe.ts
@@ -16,7 +16,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
         docs: {
             description:
                 'Nested describe block should be less than set max value or default value',
-            recommended: 'error'
+            recommended: 'strict'
         },
         schema: [
             {

diff --git a/src/rules/no-disabled-tests.ts b/src/rules/no-disabled-tests.ts
@@ -11,7 +11,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
         type: 'suggestion',
         docs: {
             description: 'Disallow disabled tests',
-            recommended: false
+            recommended: 'strict'
         },
         messages: {
             missingFunction: 'Test is missing function argument',

diff --git a/src/rules/no-done-callback.ts b/src/rules/no-done-callback.ts
@@ -27,9 +27,9 @@ export default createEslintRule<Options, MessageIds>({
         type: 'suggestion',
         docs: {
             description: 'Disallow using a callback in asynchronous tests and hooks',
-            recommended: 'error'
+            recommended: 'strict'
         },
-		deprecated: true,
+        deprecated: true,
         schema: [],
         messages: {
             noDoneCallback: 'Return a promise instead of relying on callback parameter',

diff --git a/src/rules/no-restricted-vi-methods.ts b/src/rules/no-restricted-vi-methods.ts
@@ -11,7 +11,7 @@ export default createEslintRule<Options, MESSAGE_ID>({
         type: 'suggestion',
         docs: {
             description: 'Disallow specific `vi.` methods',
-            recommended: false
+            recommended: 'strict'
         },
         schema: [{
             type: 'object',

diff --git a/src/rules/prefer-strict-equal.ts b/src/rules/prefer-strict-equal.ts
@@ -12,7 +12,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
         type: 'suggestion',
         docs: {
             description: 'Prefer strict equal over equal',
-            recommended: 'warn'
+            recommended: 'strict'
         },
         messages: {
             useToStrictEqual: 'Use `toStrictEqual()` instead',

diff --git a/src/rules/valid-expect.ts b/src/rules/valid-expect.ts
@@ -97,7 +97,7 @@ export default createEslintRule<[
     meta: {
         docs: {
             description: 'Enforce valid `expect()` usage',
-            recommended: 'error'
+            recommended: 'strict'
         },
         messages: {
             tooManyArgs: 'Expect takes most {{ amount}} argument{{s}}',

diff --git a/tests/consistent-test-it.test.ts b/tests/consistent-test-it.test.ts
@@ -6,21 +6,21 @@ ruleTester.run(RULE_NAME, rule, {
   valid: [
     {
       code: `it("shows error", () => {
-						expect(true).toBe(false);
-					});`,
+		expect(true).toBe(false);
+        });`,
       options: [{ fn: TestCaseName.it }]
     },
     {
       code: `it("foo", function () {
-						expect(true).toBe(false);
-					})`,
+	        expect(true).toBe(false);
+	    })`,
       options: [{ fn: TestCaseName.it }]
     },
     {
       code: `	it('foo', () => {
-						expect(true).toBe(false);
-					});
-					function myTest() { if ('bar') {} }`,
+		    expect(true).toBe(false);
+		});
+		function myTest() { if ('bar') {} }`,
       options: [{ fn: TestCaseName.it }]
     }
   ],

diff --git a/tsconfig.json b/tsconfig.json
@@ -0,0 +1,13 @@
+{
+  "$schema": "https://json.schemastore.org/tsconfig",
+  "compilerOptions": {
+    "target": "es2016",
+    "module": "Node16",
+    "esModuleInterop": true,
+    "forceConsistentCasingInFileNames": true,
+    "strict": true,
+    "skipDefaultLibCheck": true,
+    "skipLibCheck": true,
+  },
+  "include": [ "**/*.ts" ]
+}