Skip to content

Commit

Permalink
feat: updated
Browse files Browse the repository at this point in the history
  • Loading branch information
veritem committed Mar 29, 2023
2 parents 8af7c70 + b5c1d2f commit 4d4cc3d
Show file tree
Hide file tree
Showing 5 changed files with 791 additions and 2 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,11 @@ To use the all configuration, extend it in your `.eslintrc` file:
| [prefer-each](docs/rules/prefer-each.md) | Prefer `each` rather than manual loops | 🌐 | | |
| [prefer-equality-matcher](docs/rules/prefer-equality-matcher.md) | Suggest using the built-in quality matchers | 🌐 | | 💡 |
| [prefer-expect-resolves](docs/rules/prefer-expect-resolves.md) | Suggest using `expect().resolves` over `expect(await ...)` syntax | 🌐 | 🔧 | |
<<<<<<< HEAD
| [prefer-hooks-on-top](docs/rules/prefer-hooks-on-top.md) | Suggest having hooks before any test cases | 🌐 | | |
=======
| [prefer-hooks-in-order](docs/rules/prefer-hooks-in-order.md) | Prefer having hooks in consistent order | 🌐 | | |
>>>>>>> origin
| [prefer-lowercase-title](docs/rules/prefer-lowercase-title.md) | Enforce lowercase titles | 🌐 | 🔧 | |
| [prefer-strict-equal](docs/rules/prefer-strict-equal.md) | Prefer strict equal over equal | 🌐 | | 💡 |
| [prefer-to-be](docs/rules/prefer-to-be.md) | Suggest using toBe() || 🔧 | |
Expand Down
30 changes: 30 additions & 0 deletions docs/rules/prefer-hooks-in-order.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Prefer having hooks in consistent order (`vitest/prefer-hooks-in-order`)

⚠️ This rule _warns_ in the 🌐 `all` config.

<!-- end auto-generated rule header -->

```js
// consistent order of hooks
['beforeAll', 'beforeEach', 'afterEach', 'afterAll']
```

```js
// bad
afterAll(() => {
removeMyDatabase();
});
beforeAll(() => {
createMyDatabase();
});
```

```js
// good
beforeAll(() => {
createMyDatabase();
});
afterAll(() => {
removeMyDatabase();
});
```
7 changes: 5 additions & 2 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import preferStrictEqual, { RULE_NAME as preferStrictEqualName } from './rules/p
import preferExpectResolves, { RULE_NAME as preferExpectResolvesName } from './rules/prefer-expect-resolves'
import preferEach, { RULE_NAME as preferEachName } from './rules/prefer-each'
import preferHooksOnTop, { RULE_NAME as preferHooksOnTopName } from './rules/prefer-hooks-on-top'
import preferHooksInOrder, { RULE_NAME as preferHooksInOrderName } from './rules/prefer-hooks-in-order'

const createConfig = (rules: Record<string, string>) => ({
plugins: ['vitest'],
Expand Down Expand Up @@ -79,7 +80,8 @@ const allRules = {
[preferStrictEqualName]: 'warn',
[preferExpectResolvesName]: 'warn',
[preferEachName]: 'warn',
[preferHooksOnTopName]: 'warn'
[preferHooksOnTopName]: 'warn',
[preferHooksInOrderName]: 'warn'
}

const recommended = {
Expand Down Expand Up @@ -130,7 +132,8 @@ export default {
[preferStrictEqualName]: preferStrictEqual,
[preferExpectResolvesName]: preferExpectResolves,
[preferEachName]: preferEach,
[preferHooksOnTopName]: preferHooksOnTop
[preferHooksOnTopName]: preferHooksOnTop,
[preferHooksInOrderName]: preferHooksInOrder
},
configs: {
all: createConfig(allRules),
Expand Down

0 comments on commit 4d4cc3d

Please sign in to comment.